* Move to the hack' script inflator
* Skip kn subpackage
* Move the lib/ to public pkg/ packages
* Introduce pkg submodule, remove the vendor dir
* Remove vendor references
* Use latest version of knative.dev/hack
* Publish dependent images properly
* Walkaround for knative-extensions/net-istio#1345
* Remove GOTOOLCHAIN in go.work
* Verify codegen use common funcs
* Import code from knative.dev/client-pkg
* Restore the default unit test runner
* Try knative/actions#223
* Restore the workflows
* Nit: simplify config package import
* Calculate traffic split when N-1 revisions are specified
* Added test cases for traffic split
* enhanced error messages and added example
* added e2e test
* refactored verifyInput function
* Update docs/cmd/kn_service_update.md
Co-authored-by: Navid Shaikh <shaikhnavid14@gmail.com>
* Update pkg/kn/commands/service/update.go
Co-authored-by: Navid Shaikh <shaikhnavid14@gmail.com>
* added unit test for revision list error
Co-authored-by: Navid Shaikh <shaikhnavid14@gmail.com>
* update: Change default to server-side generated revision names
Fixes#1144
* update: Fix wait loop for synthetic events for which the generations are already in sync
* fix assertion as a service label change does not create a new revision
* fix: --cluster-local does not create a new revision but just changes a service's label
* chore: Fixed formatting
* update: Check generation in update already before doing a watch
* fixed lint issue
* fix test assertions
* return error message from using --untag with nonexistent tag
* improve err message for --untag and add e2e test
* change untagRevision to return bool and add traffic e2e tests
* update changelog
* fix(e2e): Refactor e2e utils and resource actions
brings commonly re-used utilities into lib/test so they can be resused
and e2e can be run selectively for eventing/serving.
* Refactor service and revision e2e test utils into test lib
* Docstrings for exported e2e test utils
* (refactor) address the e2e extract / refactor of issue #763
* various updates to address reviewers feedback
* renamed lib/test/integration to lib/test and package to test
* chore(e2e): Refactor e2e to better track errors
* Collect results from various `kn` calls to
provide the context
* Changed sub-Run() commands to t.Log() to reduce
the log noise and get file + line information
in the log output
* Removed any Fatal() calls to allows the test
to properly finish
* Only output via t.Log() to get the output at the
proper places and allow Prow to better pick
up the test results.
* Most important: EMOJIS !! 🦆🦆🦆🦆🦆
* chore(e2e): Add more dumpers
* Moar debug
- Run only serving specific e2e tests locally
```
E2E_TAGS="serving" ./test/e2e-tests-local.sh
```
- Run only eventing specific e2e tests locally
```
E2E_TAGS="eventing" ./test/e2e-tests-local.sh
```
- Run all e2e tests locally
```
./test/e2e-tests-local.sh
```
Related to #500
- The fix for serving#6060 merged (serving#6069), removing the workaround
at client side e2e tests for additional LCR=LRR check after service update return.
- Now we expect service status to have LCR=LRR if the service's conditions turned True after last update.
* Uses BYO revision names for traffic splitting e2e tests
- Avoid getting the revision name after service create/update using LCR or LRR from service status
* Pauses 3 seconds before verifying actual vs expected traffic targets
- for traffic splitting e2e tests
- Check the comment on https://github.com/knative/client/issues/500#issuecomment-554355688
* fix(version): Displays supported APIs and version
Fixes#404
```
./kn version
Version: v20191017-local-6328a73-dirty
Build Date: 2019-10-17 09:55:55
Git Revision: 6328a73
Supported APIs:
- serving.knative.dev/v1alpha1 (knative-serving v0.8.0)
```
* Removes ServingVersion feeding from ldflags
- hardcodes the supported APIs as they're supposed to be updated when we bump deps
* Fixes typo in e2e tests
* Uses array for deterministic order of printing supported APIs
* fix(e2e): Improves the error message upon mismatch of traffic targets
Fixes#434
- The error message now prints the expected/actual length of traffic targets
- Also prints the actual traffic targets
* Fixes Golint errors
Golint errors: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...).
* Increased default timeout to 600s. This timeout will be triggered
only when the Ready condition stays in UNKNOWN for that long. If its
True or False then the command will return anyway sooner.
So it makes sense to go for a much longer timeout than 60s
* Enhanced output to indicate the progress
This change needs some updates to the API and introduces a 'MessageCallback'
type which is calle for each intermediate event with the "Ready" condition message.
* fix typo (misspell)
* ineffectual assignment to err (ineffassign)
* if block ends with a return statement, so drop this else and outdent its block (golint)
* should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (golint)
* struct field LogHttp should be LogHTTP (golint)
* fix last typo
* Update serving to 0.8. Try building.
* Find the right serving version
* Change our own import path to knative.dev to match
* Remove dependency on old version of client
* Update yaml template
* Add sleep to test to deal with race
* fix merge conflict
* Update vendor modules
- Add e2e tests
- Use '=' for traffic and tag assignment instead of ':'
- Use --tag and --untag flags for tagging traffic targets
- Use --traffic flag for setting traffic portions
- Allow --traffic portion to either take revisionName or tagName
- Uses @latest identifier for referencing latest revision of service
- Dont throw error if requested revision=tag pair is same
- Support having multiple tags for a revision
- creates a new target in traffic block if revision present in traffic block with new tag requested
- creates N new targets in traffic block if revision absent in traffic block with Nxnew tags requested
- Ensure updating tag of @latest requires --untag flag
- streamline updating tag for latestReadyRevision
- adds respective tests
- adds tests for ensuring given traffic sum to 100 on CLI and fail fast
- Add note about preference of order in case where tagOfOneRevision == revisionOfAnother,
first tags are checked and assigned traffic if any, as tags are supposed to be
unique in traffic block and should be referenced in such scenario.
- Remove the examples from flag description, moves it to service update command example section
- Pass only traffic block to compute trffic, makes it better to consume.
- Cover more error cases for invalid value format for assignments, covers a=b=c, a=, =b, or variants of them
- Separate and improves the error messages
- Add unit tests for traffic computing
- Add sanity checks in dedicated function verifyInputSanity
- traffic perents should sum to 100
- individual percent should be in 0-100
- repetition of @latest or tagName or revisionRef is disallowed
- Verify traffic percents sum to 100 on client side and fail fast
- Add e2e tests for traffic splitting
- create and update service, assign tags and set traffic to make an existing state
- run the scenario on existing state of service
- form the desired state traffic block
- extract the traffic block and form the traffic block struct actual state
- assert.DeepEqual actual and desired traffic blocks
- Use logic to generate service name in the same way as namespace, use different service name per test case
- Run e2e test for traffic splitting in parallel
- Use timeout duration of 30m for e2e tests, use timeout parameter for go_test_e2e library function
- Use tagName in flag description of --untag, avoiding conflict with --tag flag
- Update CHANGELOG
Chris Suszynski