mirror of https://github.com/knative/client.git
7 Commits
| Author | SHA1 | Message | Date |
|---|---|---|---|
Yevhen Vydolob
|
563f1d9294
|
Fix service/revision list output with '-o' param (#1276)
* Fix service/revision list output with '-o' param Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Update CHANGELOG Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Simplify output flag check Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Respect '-o' in all list commands Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix imports Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix e2e test Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix e2e test Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Remove unnecessary import Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix import Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> * Fix tests Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com> |
|
|
Matej Vasek
|
c62842355a
|
Use context.Context in API methods (#1274)
* Refactor: add ctx param to KnServingClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from knServingClient to ServingV1Interface
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Making wait function cancellable
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Handling SIGINT and SIGTERM
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnEventingClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from knServingClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fixup style
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Removing unnecessary dependency
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnChannelsClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from knServingClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnSubscriptionsClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from subscriptionsClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnSinkBindingClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from knBindingClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnDynamicClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from knDynamicClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnAPIServerSourcesClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from APIServerSourcesRecorder to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnContainerSourcesClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from containerSourcesClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: add ctx param to KnPingSourcesClient funs
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Passing ctx from pingSourcesClient to knative.dev interfaces
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Using cmd.Context() in pkg/kn/commands
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Test using background ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Removing ctx param from RawClient()
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* ctx for watch/polling
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fix per review request
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: extract ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Refactor: Namespace not requiring ctx
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* fixup
Signed-off-by: Matej Vasek <mvasek@redhat.com>
* Revert "Handling SIGINT and SIGTERM"
This reverts commit
|
|
|
Josh Soref
|
4939c5ede3
|
Fix various misspellings and linter items (#1057)
* spelling: additional Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: bindings Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: blocked Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: bootstrap Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: channel Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: channel Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: commands Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: comparison Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: configuration Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: controller Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: convert Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: desired Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: dynamic Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: entry Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: execute Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: explicit Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: hardcoded Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: information Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: inject Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: item Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: kubectl Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: latest Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: message Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: namespace Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: namespaces Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: output Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: overriding Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: parameters Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: revision Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: separated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: separator Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: service Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: specified Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: specifies Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: splitting Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: subscription Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: trigger Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unknown Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unstructured Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: workflow Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * chore: Address golinter complaint for (c *MockKnServingClient) GetBaseRevision Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * chore: update changelog for spelling fixes (#1057) |
|
|
Roland Huß
|
b916a5b3ed
|
Add grouping for help message + streamlined help messages (#887)
* Add grouping for help message + streamlined help messages The top-level looks like kn is the command line interface for managing Knative Serving and Eventing objects Find more information about Knative at: https://knative.dev Serving Commands: service Manage Knative services revision Manage service revisions route List and show service routes Eventing Commands: source Manage event sources trigger Manage event triggers Other Commands: plugin Manage kn plugins completion Output shell completion code version Show the version of this client Use "kn <command> --help" for more information about a given command. Use "kn options" for a list of global command-line options (applies to all commands). The following changes have been applied: * Add CommandGroups for grouping commands together * Add flexible templating for the help messages * Moved global options to an own command ('kn options', much like 'kubectl options') * Aligned wording and typography of help messages These features has been highly inspired by kubectl grouping & help templating but has been considerably been stripped down to the needs of kn. Signed-off-by: Roland Huß <roland@ro14nd.de> * chore: Add missing file * Update pkg/templates/command_groups.go Co-authored-by: Matt Moore <mattmoor@vmware.com> * chore: Add some test for error messages * fix formatting * chore: Add test * moar tests * Update pkg/kn/commands/completion/completion.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/source/apiserver/delete.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/service/list.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/route/route.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/revision/delete.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/plugin/plugin.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/service/delete.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/revision/delete.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * Update pkg/kn/commands/service/delete.go Co-authored-by: Navid Shaikh <nshaikh@redhat.com> * regen docs * chore: Update conventions doc * Move some direct configuration of rootcmd to NewRootCommand() * Moved CaptureOutput to "test" package for reuse Co-authored-by: Matt Moore <mattmoor@vmware.com> Co-authored-by: Navid Shaikh <nshaikh@redhat.com> |
|
|
Ying Chun Guo
|
2225b4c8dd
|
Fix resource listing with -oname flag (#799)
* Fix resource listing with -oname flag * add e2e tests |
|
|
Navid Shaikh
|
a44833c849
|
fix typo in source list-types examples (#684)
* Fix typo in kn source list-types example * Update other list command examples |
|
|
Roland Huß
|
164cb5f362
|
feature(source binding): Support for Sink Binding as source (#625)
* feature(source binding): Support for Sink Binding as source Sink bindings are managed like any other source. Sinks are specified as usual (with prefix and name), 'subjects' (the other end of the binding) is managed via a shortcut notation: * with name: `<kind>:<apiVersion>:<name>` * with label selector: `<kind>:<apiVersion>:key1=value1,key2=value2` With `--subject-namespace` and additional namespace can be provided (shoudl be possible for a sink, too but is not yet) The implementation already uses the new sink binding from the `sources.knative.dev` group and hence is a bit inconsistent to the still old usage kf `sources.eventing.knative.dev` for apiserver source and cronjob. However as we will move over to `sources.knative.dev` very soon (right after v0.12.0) release, this is was more appropriates. Still WIP, but eventually fixes #624 Task list: - [X] create - [] update - [] delete - [] describe - [] list * fix(source binding): Added missing commands Also, it looks like that knative eventing 0.12.0 is still on the old api group. So I need to move this code to use the legacyclient, too, for the sink binding and only switch over to the new client for 0.13.0 * feature(source binding): Added missing subcommands * update * delete * list * describe * fix(source binding): Removed --subject-namespace as this namespace cant b set. Tuned describe output a bit. * feat(source binding) add support for CeOverride * fix: Worked on review comments * fix: review comments * fix: names in binding client |