client

Commit Graph

Author	SHA1	Message	Date
Roland Huß	98184eafbc	refactor(serving): KnClient interface for single point of cluster access (#134 ) * fix(serving): Remove hardcoded GVK and look it up from schema Fixes #133. * chore(serving): Add test for "WaitForService()" * refactor(service): Add listRoutes() to client + generic way for list options * chore(serving): Fixing rebase conflicts	2019-07-08 10:08:34 -07:00
Navid Shaikh	fc9b24c1e5	Add custom comparison for checking multiple substrings (#227 ) * Adds custom comparison for checking multiple substrings This changeset introduces custom comparison for checking if a target string has given multiple substrings, namely `ContainsMultipleSubstrings`. Also removes `commands.TestContains` function and replaces all references of `commands.TestContains` with `gotest.tools/assert.Check` function and uses `ContainsMultipleSubstrings` as comparison function. * Renames and makes the compare function variadic New name: ContainsAll New location: pkg/util/compare.go Also the function now takes target string as first arg, and accepts any number of substrings to check. Removed the message arg, the compare function composes the error message. For eg: ``` Actual output: foo-abcd foo <unknown> 0 OK / 0 <unknown> <unknown> Missing strings: foo-abcd1, foo1 ``` * Adds tests for compare utility ContainsAll * Update vendor/modules.txt	2019-07-05 10:07:32 -07:00
Navid Shaikh	d25ea5f1e7	Renames service 'get' to 'list' (#179 ) * Renames service 'get' to 'list' As per title. * Renames get references to list in e2e tests * Replaces get to list in docs	2019-06-13 13:56:43 -07:00

Author

SHA1

Message

Date

Roland Huß

98184eafbc

refactor(serving): KnClient interface for single point of cluster access (#134 )

* fix(serving): Remove hardcoded GVK and look it up from schema

Fixes #133.

* chore(serving): Add test for "WaitForService()"

* refactor(service): Add listRoutes() to client + generic way for list options

* chore(serving): Fixing rebase conflicts

2019-07-08 10:08:34 -07:00

Navid Shaikh

fc9b24c1e5

Add custom comparison for checking multiple substrings (#227 )

* Adds custom comparison for checking multiple substrings

 This changeset introduces custom comparison for checking if a target
 string has given multiple substrings, namely `ContainsMultipleSubstrings`.

 Also removes `commands.TestContains` function and replaces all references
 of `commands.TestContains` with `gotest.tools/assert.Check` function and
 uses `ContainsMultipleSubstrings` as comparison function.

* Renames and makes the compare function variadic

 New name: ContainsAll
 New location: pkg/util/compare.go
 Also the function now takes target string as first arg,
 and accepts any number of substrings to check.
 Removed the message arg, the compare function composes the error message.
 For eg:
```
        Actual output: foo-abcd   foo       <unknown>   0 OK / 0     <unknown>   <unknown>
        Missing strings: foo-abcd1, foo1
```

* Adds tests for compare utility ContainsAll

* Update vendor/modules.txt

2019-07-05 10:07:32 -07:00

Navid Shaikh

d25ea5f1e7

Renames service 'get' to 'list' (#179 )

* Renames service 'get' to 'list'

 As per title.

* Renames get references to list in e2e tests

* Replaces get to list in docs

2019-06-13 13:56:43 -07:00

3 Commits