Commit Graph

4 Commits

Author SHA1 Message Date
Tsubasa Nagasawa b7808b0fa2 Validate scale and container concurrency options when updating configuration resource (#279)
* Validate invalid container concurrency options

* Use assert package

* Use FlagSet.Changed and don't care about default values

* Update dependency

* Follow e2e test changes

* Return error if invalid value is specified by users

* Fix broken e2e test

* Add more unit tests

* Fix error message

* Fix comment statement

* Revert back unrelated changes

* Fix typo
2019-07-25 02:57:35 -07:00
dr.max 9513dedfba Improves(e2e): imrpoves integration tests and to better run locally (#274)
1. refactors basic workflow (move code to common)
2. use different namespace accross test runs to isolate
3. include wait logic in CreateNamespace to allow multiple runs
4. include wait logic in DeleteNamespace to allow multiple runs

This is important since we need more integration tests and some of
these changes should allow `./test/e2e-tests-local.sh` to run on
local clusters (minikube or something other than test-infra) and
correctly behave during mutiple runs.
2019-07-23 10:13:34 -07:00
Tsubasa Nagasawa fca0a09e86 Clean up e2e test assertion (#264)
* Clean up e2e test assertion

Heavily rely on assert package as well as unit tests

* Iterate over a line for ensuring valid output

* Use subtests for easily spotting the error location
2019-07-15 04:41:26 -07:00
Tsubasa Nagasawa 406ecd182d Add e2e tests for service with concurrency options (#256)
* Add e2e tests for service with concurrency options

Check the behaviour of creating/updating service with concurrency options

* Move tests into separate test file and fix neats

* Use assert package for error check

* Change test function name
2019-07-12 10:24:41 -07:00