Commit Graph

483 Commits

Author SHA1 Message Date
Navid Shaikh 2fcf5adbbe
chore: Update test-infra (#742) 2020-03-17 06:48:31 -07:00
Roland Huß db569fae17
chore: Update changelog.adoc (#736)
* chore: Update changelog.adoc

* update date

* Update CHANGELOG.adoc

Co-Authored-By: Navid Shaikh <nshaikh@redhat.com>

Co-authored-by: Navid Shaikh <nshaikh@redhat.com>
2020-03-11 01:24:29 -07:00
Ying Chun Guo 5ed62c801a
Verify "source ping describe" in ping e2e test (#727) 2020-03-11 00:32:29 -07:00
Doug Davis a69daf4f8f
missing paren (#735)
Signed-off-by: Doug Davis <dug@us.ibm.com>
2020-03-11 00:03:28 -07:00
dr.max e5880be8d5
fix: typo in issue template feature-request.md file (#734) 2020-03-10 14:57:29 -07:00
dr.max 2b9377d195
fixes(#606): adds --cluster-local / --no-cluster-local flags (#629)
When specified on 'service create' the '--cluster-local' flag will
make the created service 'private' by setting its config visibility
to 'cluster-local'. This is done with label:

serving.knative.dev/visibility: cluster-local

The --no-cluster-local will remove the label.
2020-03-10 14:24:29 -07:00
David Simansky 5ee9785b5f
fix(e2e): make local-e2e-tests.sh executable (#731) 2020-03-10 13:07:29 -07:00
David Simansky 8dbf4394a1
feat(trigger): add --inject-broker flag to trigger create command (#726)
* feat(trigger): annotate trigger to inject default broker

* chore: update changelog

* fix: reflect review feedback

* fix: code comment wording

* fix: reflect review feedback
2020-03-10 11:32:28 -07:00
Navid Shaikh 0d70b61615
chore(e2e): Support parsing int64 user id in test verification (#730) 2020-03-10 10:53:29 -07:00
Roland Huß a0f13548a6
chore(service export): Rename `--history` to `--with-revisions` (#729) 2020-03-10 10:04:28 -07:00
Navid Shaikh 74e43b8806
Report missing kubeconfig or error connecting to cluster (#725)
Fixes #315
 - Improve error reporting if
    - kubeconfig file is missing or
    - there is no route to host
    - i/o timeout
2020-03-10 03:34:29 -07:00
Murugappan Chetty 5c794d3b04
add "kn service export" (#653) (#669)
* add kn export (#653)

* add kn export (#653)

* review comments for #669

* add kn export command

* add kn export command

* add kn export command

* add kn export command

* add changelog for pr 679

* add changelog

* review comments for pr #669

* review comments for pr #669

* review comments for kn export
2020-03-10 02:53:28 -07:00
Navid Shaikh ba7e14c807
feat(source): Add 'kn source list' (#666)
* feat(source): Add 'kn source list'

 Fixes #480
 - Add 'kn source list' listing the available sources COs
 - Use dynamic client to
       - find out available source types
       - find the COs in given namespace for each source type
 - Add --type flag to filter source list based on source type
 - Add unit tests
 - Add e2e tests
 - Add CHANGELOG entry

* Update group for ApiServerSource in tests

* Add kn duck source type for holding common eventing source fileds

 - Common infromation from sources are extracted into a struct
   for source list command output
 - Printer function picks the information from this struct object
   and doesn't know the details about extracting this info from multiple
   types of sources received
 - Group and Version for list is set to empty string and Kind to 'List',
   if printed a source list with multiple types of sources in machine readable
   format
 - Group, Version and Kind for list are kept intact if printed a source list
   with same type of source objects in machine readable format

* Update go.sum

* Add WithType builder for listing source

 - Separate the flags definition
 - WithType builder can be re-used to filter the source types
 - Add unit tests

* Update ApiServer source group to apiserversources.sources.knative.dev

* Fix typos and align

Co-authored-by: Roland Huß <roland@ro14nd.de>
2020-03-10 00:41:28 -07:00
Ying Chun Guo 29087e64ff
chore: fix a typo in pull request template (#720) 2020-03-09 20:50:28 -07:00
Shashwathi 81c1d9ce03
Add option for adding labels only to service and/or template (#703)
* Add option for adding labels only to service and/or template

In this PR we are introducing 2 additional flags for setting label for
service(label-service) and revision(label-revision) only.

Signed-off-by: Andrew Su <asu@pivotal.io>

* Update docs

Signed-off-by: Andrew Su <asu@pivotal.io>

* Add changelog entry

Signed-off-by: Andrew Su <asu@pivotal.io>

* Refactor UpdateLabels method to be more generic.

* Refactored labels common code.

Signed-off-by: Shash Reddy <shashwathireddy@gmail.com>

* Pass pointer refernce instead of copy to update labels

Co-authored-by: Roland Huß <roland@ro14nd.de>
Co-authored-by: Andrew Su <asu@pivotal.io>
2020-03-09 14:02:28 -07:00
Navid Shaikh 14a5e83765
feat(version): Add JSON/YAML output formats for version command (#709)
* feat(version): Add JSON/YAML output format for version command

 Fixes #513

* Loop for supported apis in template
2020-03-09 11:11:29 -07:00
Navid Shaikh 158c8f8980
fix(e2e): Restore local e2e test script (#708)
* fix(e2e): Restore local e2e test script

* Rename script to local-e2e-tests.sh and update test README
2020-03-09 10:46:32 -07:00
Navid Shaikh 21ce981963
fix(docs): Revert markdown changes for cobra's auto-docs (#715)
Revert sub-set of changes from https://github.com/knative/client/pull/710 which
 are auto-generated by cobra.
2020-03-09 09:58:29 -07:00
Matt Moore f9ccf36518
Format markdown (#710)
Produced via:
  `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
/assign maximilien rhuss
/cc maximilien rhuss
2020-03-09 09:19:28 -07:00
Matt Moore c75cc2d958
Fix spelling errors (#712)
Produced via:
  `github.com/client9/misspell`
/assign maximilien rhuss
/cc maximilien rhuss
2020-03-09 08:33:28 -07:00
Navid Shaikh 34433f635e
fix(docs): Fix links to knative install and relative reference (#714)
- Setup Knative now points to https://knative.dev/docs/install/any-kubernetes-cluster/
 - Corrects the local link to docs/DEVELOPMENT.md
2020-03-09 08:05:28 -07:00
Matt Moore c0e5cd1d8d
golang format tools (#711)
Produced via:
  `gofmt -s -w $(find -path './vendor' -prune -o -path './third_party' -prune -o -type f -name '*.go' -print)`
  `goimports -w $(find -name '*.go' | grep -v vendor | grep -v third_party)`
/assign maximilien rhuss
/cc maximilien rhuss
2020-03-09 07:45:28 -07:00
Roland Huß 56e14653c5
chore: Add option to generate frontmatter to gendocs. (#680)
* chore: Cleaned up README

This is just a start for reorganizing the client side documentation.

* chore: Add option to generate frontmatter to gendocs.

This is needed for latter inclusion in knative.dev. Related to #639.
2020-03-09 04:04:28 -07:00
Matt Moore 1cbb94e2cc
Use ko's strict mode for better errors messages (#706) 2020-03-07 12:11:27 -08:00
Matt Moore 9b1e8e149c
Follow up on Roland's review comment. (#707)
See: https://github.com/knative/client/pull/704#discussion_r389242726
2020-03-07 10:12:27 -08:00
Matt Moore a9311c74e0
Setup `./hack/update-deps.sh` so that we can auto-update CLI (#704)
This script is the hook that the bots key off of to float our dependencies forward via a PR each day that lets us determine whether things have broken via Prow. In our other repos, this generally lets us know about breaking changes across repos within 1 business day, and has proven valuable.
2020-03-06 14:12:27 -08:00
Roland Huß 46d5e60e42
refactor(source): Update to Knative eventing 0.13.0 (#705)
* chore(e2e): Optimized tests

Smoke Tests now run before the E2E tests, but in the same cluster

* chore: Removed unneeded test

* fix

* fix

* fix

* fix

* chore: Update to serving & eventing v0.13.0

* refactor(source): Update to Knative eventing 0.13.0

* Moved to "sources.knative.dev" API group
* Replaced CronJobSource with PingSource (and removed unsupported options for service account, requests limits)
* Move to versions:
  - SinkBinding v1alpha2
  - PingSource v1alpha2
  - ApiServerSource v1alpha1

* update to eventing 0.13.1

* go.sum fix

* fixed test

* test updates

* try to enhance error output

* fix test.

* update tests infra to 0.13.1
2020-03-06 13:47:27 -08:00
Knative Prow Robot 50a36b4ba7
fix(wait): Only use MODIFIED events when waiting for Read == True (#701) 2020-03-04 13:38:54 -08:00
Ying Chun Guo e6c7d2859d
Add serviceaccount & resources config to cronjob source (#665)
Co-authored-by: Roland Huß <rhuss@redhat.com>
2020-03-04 00:51:53 -08:00
Navid Shaikh 136de19775
Re-enable markdown link check (#693)
* Re-enable markdown link check

 As https://github.com/raviqqe/liche/issues/33 is now fixed

* Update test-infra to latest
2020-03-03 09:22:53 -08:00
Roland Huß 5e3f4d7f17
chore: Cleanup templates and tuned icons (#697)
I.e. removed the sponge icon with some star dust and added a refactoring icon.

Also the templates has been streamlined wrt/ to questions, and a
"free form" template has been added, without structure.
2020-03-03 07:45:53 -08:00
Roland Huß 4af20afebb
chore: Cleaned up README (#677)
* chore: Cleaned up README

This is just a start for reorganizing the client side documentation.

* fix: link

* chore(README): Fix link

* chore: fixed link

* review fixes

* minor wording
2020-03-03 04:44:53 -08:00
Navid Shaikh c1f3eb867b
fix(e2e): Update revision e2e tests (#696)
Fixes #695
 - Re-order revision tests operations to avoid any race condition that
   may cause.
2020-03-02 00:47:52 -08:00
Murugappan Chetty b95f40e2fe
add e2e for user flag (#692) 2020-02-29 09:22:52 -08:00
David Simansky b14dc2dc7f
feat(wait): add sync revision delete operation (#688) 2020-02-29 06:09:51 -08:00
David Simansky 034a9b387e
feat(XDG home): use XDG_CONFIG_HOME as default config location (#668)
* feat(XDG home): use XDG_CONFIG_HOME as default config location

* fix: typo in comment

* feat(XDG home): update readme and usage strings
2020-02-28 06:24:51 -08:00
Murugappan Chetty 66173059fc
Add --user flag for service create and update (#679)
* add run as user flag #678

* add run as user flag #678

* add changelog for pr 679

* review comments  for pr 679

* review comments  for pr 679

* add test for config changes

* add user flag
2020-02-28 03:55:51 -08:00
Ying Chun Guo ab00cc2969
fix for the failure of trigger e2e test (#690) 2020-02-28 02:36:51 -08:00
Ying Chun Guo d14c01fb5d
Allow configuration sink prefixes (#676) 2020-02-28 02:02:51 -08:00
Navid Shaikh 82381f36e4
chore(e2e): Increase e2e timeout to 45 minutes (#687)
Fixes #686

 - changed from 30m to 45m
2020-02-26 04:54:50 -08:00
Navid Shaikh e049ea9267
Disable markdown link check and enable presubmit test fail fast (#685)
sets `DISABLE_MD_LINK_CHECK=1` and `PRESUBMIT_TEST_FAIL_FAST=1`
2020-02-25 23:07:50 -08:00
David Simansky 345653bfe0
feat(wait): add wait for delete operation (#682)
* feat(wait): add wait for delete operation

* feat(wait): refactor initial impl

* fix(lint): add docs to new functions

* fix: reflect code review comments

* feat(wait): add changelog entry

* fix: changelog entry to render correctly

* fix: usage message of wait flag

* feat(wait): set foreground propagationPolicy in sync service delete

* feat(wait): add sync revision delete operation

* Revert "feat(wait): add sync revision delete operation"

This reverts commit 9bb60ac25e.
2020-02-25 02:38:50 -08:00
Navid Shaikh a44833c849
fix typo in source list-types examples (#684)
* Fix typo in kn source list-types example

* Update other list command examples
2020-02-21 03:38:06 -08:00
Roland Huß 963788b730
chore: Fix formatting error in changelog (#681) 2020-02-19 08:19:05 -08:00
Roland Huß c2dcb6b42d
chore(e2e): Minor cleanup (#670)
* chore(e2e): Minor cleanup

* chore(e2e): Remove t.Parallel() for the revision test

* chore: Some improvements wrt/ testing

* chore: fix formatting
2020-02-17 23:00:58 -08:00
Doug Davis 83b926b802
Prevent service-specific labels from being put on the revision template (#672)
See: https://github.com/knative/serving/pull/6865

Signed-off-by: Doug Davis <dug@us.ibm.com>
2020-02-17 08:58:09 -08:00
Roland Huß a220a88534
chore(e2e): Refactor to better track errors (#667)
* chore(e2e): Refactor e2e to better track errors

* Collect results from various `kn` calls to
  provide the context
* Changed sub-Run() commands to t.Log() to reduce
  the log noise and get file + line information
  in the log output
* Removed any Fatal() calls to allows the test
  to properly finish
* Only output via t.Log() to get the output at the
  proper places and allow Prow to better pick
  up the test results.
* Most important: EMOJIS !! 🦆🦆🦆🦆🦆

* chore(e2e): Add more dumpers

* Moar debug
2020-02-16 23:52:10 -08:00
Roland Huß 06d4dffd1e
feature(service update): Add generic mechanism to include retries on conflicts (#660)
* feature(service update): Add generic mechanism to include retries on conflicts

Move the retry logic for retrying in case of a resource conflict into the KnClient.

* chore: Update unit tests
2020-02-15 10:24:40 -08:00
wslyln 12d718e7af
Support multiple arguments on revision delete (#657)
* added multiple parameters to revision and added e2e test

* add to changelog

* fix changelog table

* fix warning message and revision test

* remove commented lines

* remove 'successfully' from revision output

* added requires one or more revision name

* remove absent revision pre check

* re add nonexist revision

* fixed tests
2020-02-13 22:45:40 -08:00
Roland Huß 52b56baf52
fix(service wait): Wrong check for error window (#661)
The error window introduced with #644 had a wrong conditional. Fixed that and added a test which would have detected this.

Also, this should fix some issues which we tried to detect with #659.
2020-02-13 11:18:36 -08:00