// Copyright © 2019 The Knative Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. package commands import ( "fmt" "strings" "testing" knflags "knative.dev/client/pkg/flags" "github.com/spf13/cobra" "gotest.tools/v3/assert" ) type waitTestCase struct { args []string timeoutExpected int isWaitExpected bool isParseErrorExpected bool } func TestAddWaitForReadyDeprecatedFlags(t *testing.T) { for i, tc := range []waitTestCase{ {[]string{"--no-wait"}, 60, false, false}, {[]string{}, 60, true, false}, {[]string{"--wait-timeout=120"}, 120, true, false}, // Can't be easily prevented, the timeout is just ignored in this case: {[]string{"--no-wait", "--wait-timeout=120"}, 120, false, false}, {[]string{"--wait-timeout=bla"}, 0, true, true}, } { flags := &WaitFlags{} cmd := cobra.Command{} flags.AddConditionWaitFlags(&cmd, 60, "create", "service", "ready") err := cmd.ParseFlags(tc.args) if err != nil && !tc.isParseErrorExpected { t.Errorf("%d: parse flags: %v", i, err) } if err == nil && tc.isParseErrorExpected { t.Errorf("%d: parse error expected, but got none: %v", i, err) } if tc.isParseErrorExpected { continue } // reconcile to ensure wait, no-wait behave as expected err = knflags.ReconcileBoolFlags(cmd.Flags()) assert.NilError(t, err) if flags.Wait != tc.isWaitExpected { t.Errorf("%d: wrong wait mode detected: %t (expected) != %t (actual)", i, tc.isWaitExpected, flags.Wait) } if flags.TimeoutInSeconds != tc.timeoutExpected { t.Errorf("%d: Invalid timeout set. %d (expected) != %d (actual)", i, tc.timeoutExpected, flags.TimeoutInSeconds) } } } func TestAddWaitForReadyFlags(t *testing.T) { for i, tc := range []waitTestCase{ {[]string{}, 60, true, false}, {[]string{"--wait-timeout=120"}, 120, true, false}, // Can't be easily prevented, the timeout is just ignored in this case: {[]string{"--no-wait", "--wait-timeout=120"}, 120, false, false}, {[]string{"--wait-timeout=bla"}, 0, true, true}, } { flags := &WaitFlags{} cmd := cobra.Command{} flags.AddConditionWaitFlags(&cmd, 60, "create", "service", "ready") err := cmd.ParseFlags(tc.args) if err != nil && !tc.isParseErrorExpected { t.Errorf("%d: parse flags: %v", i, err) } if err == nil && tc.isParseErrorExpected { t.Errorf("%d: parse error expected, but got none: %v", i, err) } if tc.isParseErrorExpected { continue } // reconcile to ensure wait, no-wait behave as expected err = knflags.ReconcileBoolFlags(cmd.Flags()) assert.NilError(t, err) fmt.Println("wait value") fmt.Println(flags.Wait) if flags.Wait != tc.isWaitExpected { t.Errorf("%d: wrong wait mode detected: %t (expected) != %t (actual)", i, tc.isWaitExpected, flags.Wait) } if flags.TimeoutInSeconds != tc.timeoutExpected { t.Errorf("%d: Invalid timeout set. %d (expected) != %d (actual)", i, tc.timeoutExpected, flags.TimeoutInSeconds) } } } func TestAddWaitUsageMessage(t *testing.T) { flags := &WaitFlags{} cmd := cobra.Command{} flags.AddConditionWaitFlags(&cmd, 60, "bla", "blub", "deleted") if !strings.Contains(cmd.UsageString(), "blub") { t.Error("no type returned in usage") } if !strings.Contains(cmd.UsageString(), "Do not wait") { t.Error("wrong usage message") } if !strings.Contains(cmd.UsageString(), "60") { t.Error("default timeout not contained") } if !strings.Contains(cmd.UsageString(), "deleted") { t.Error("wrong until message") } } func TestAddWaitUsageDelete(t *testing.T) { flags := &WaitFlags{} cmd := cobra.Command{} flags.AddConditionWaitFlags(&cmd, 60, "delete", "blub", "deleted") if !strings.Contains(cmd.UsageString(), "completed. (default true)") { t.Error("Delete has wrong default value for --no-wait") } } func TestAddWaitUsageWait(t *testing.T) { flags := &WaitFlags{} cmd := cobra.Command{} flags.AddConditionWaitFlags(&cmd, 60, "wait", "blub", "ready") if !strings.Contains(cmd.UsageString(), "blub") { t.Error("no type returned in usage") } if !strings.Contains(cmd.UsageString(), "60") { t.Error("default timeout not contained") } if !strings.Contains(cmd.UsageString(), "ready") { t.Error("wrong until message") } }