From 2078ae3723cf4c249d4f569b2891e67366cb88ee Mon Sep 17 00:00:00 2001 From: Steren Date: Tue, 15 Jan 2019 10:18:31 -0800 Subject: [PATCH] Add link to image in Dockerhub (#747) * Add link to image in Dockerhub Mainly for consistency with other samples. * also README * Fixes indentation issue causing build test failure * fix bullet list indentation * attempt #2 -- fixing build failure --- serving/samples/helloworld-go/Dockerfile | 1 + serving/samples/helloworld-go/README.md | 10 +++++----- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/serving/samples/helloworld-go/Dockerfile b/serving/samples/helloworld-go/Dockerfile index 7ded73583..cc8b481c3 100644 --- a/serving/samples/helloworld-go/Dockerfile +++ b/serving/samples/helloworld-go/Dockerfile @@ -1,5 +1,6 @@ # Use the offical Golang image to create a build artifact. # This is based on Debian and sets the GOPATH to /go. +# https://hub.docker.com/_/golang FROM golang as builder # Copy local code to the container image. diff --git a/serving/samples/helloworld-go/README.md b/serving/samples/helloworld-go/README.md index 744e591b4..45211aa4a 100644 --- a/serving/samples/helloworld-go/README.md +++ b/serving/samples/helloworld-go/README.md @@ -61,6 +61,7 @@ recreate the source files from this folder. ```docker # Use the offical Golang image to create a build artifact. # This is based on Debian and sets the GOPATH to /go. + # https://hub.docker.com/_/golang FROM golang as builder # Copy local code to the container image. @@ -136,11 +137,10 @@ folder) you're ready to build and deploy the sample app. ``` 1. Now that your service is created, Knative will perform the following steps: - - - Create a new immutable revision for this version of the app. - - Network programming to create a route, ingress, service, and load balance - for your app. - - Automatically scale your pods up and down (including to zero active pods). + - Create a new immutable revision for this version of the app. + - Network programming to create a route, ingress, service, and load balance + for your app. + - Automatically scale your pods up and down (including to zero active pods). 1. Run the following command to find the external IP address for your service. The ingress IP for your cluster is returned. If you just created your