From 2e839ace71f0764997d73224768fb4585f362a87 Mon Sep 17 00:00:00 2001 From: Grant Timmerman Date: Fri, 2 Aug 2019 11:13:44 -0700 Subject: [PATCH] feat: Use latest Node LTS for samples (#1640) --- docs/serving/samples/hello-world/helloworld-nodejs/Dockerfile | 4 ++-- docs/serving/samples/hello-world/helloworld-nodejs/README.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/serving/samples/hello-world/helloworld-nodejs/Dockerfile b/docs/serving/samples/hello-world/helloworld-nodejs/Dockerfile index 222958cee..5bf4b67c9 100644 --- a/docs/serving/samples/hello-world/helloworld-nodejs/Dockerfile +++ b/docs/serving/samples/hello-world/helloworld-nodejs/Dockerfile @@ -1,6 +1,6 @@ -# Use the official Node.js 10 image. +# Use the official Node.js 12 image. # https://hub.docker.com/_/node -FROM node:10 +FROM node:12 # Create and change to the app directory. WORKDIR /usr/src/app diff --git a/docs/serving/samples/hello-world/helloworld-nodejs/README.md b/docs/serving/samples/hello-world/helloworld-nodejs/README.md index e7ee54a8b..ba696cfa8 100644 --- a/docs/serving/samples/hello-world/helloworld-nodejs/README.md +++ b/docs/serving/samples/hello-world/helloworld-nodejs/README.md @@ -95,9 +95,9 @@ cd knative-docs/docs/serving/samples/hello-world/helloworld-nodejs [Dockerizing a Node.js web app](https://nodejs.org/en/docs/guides/nodejs-docker-webapp/). ```Dockerfile - # Use the official Node.js 10 image. + # Use the official Node.js 12 image. # https://hub.docker.com/_/node - FROM node:10 + FROM node:12 # Create and change to the app directory. WORKDIR /usr/src/app