knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix getting domain name in Getting Started with Knative App Deployment (#993) 

* Fixed getting domain name

Domain information is available in the route resource and not the the knative service. Updating sample command to reflect the change.

Environment GKE 1.11.7-gke.4, Knative 0.4.0

* updated HOST_URL script to use route
This commit is contained in:
Mohamed Osman 2019-03-26 09:50:50 +11:00 committed by Knative Prow Robot
parent 2fcf0fa69d
commit 2fdc4bbed9
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/install/getting-started-knative-app.md
View File

@ -132,7 +132,7 @@ assigned an external IP address.
1. To find the host URL for your service, enter: 1. To find the host URL for your service, enter:
```shell ```shell
kubectl get ksvc helloworld-go --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain kubectl get route helloworld-go --output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain
NAME DOMAIN NAME DOMAIN
helloworld-go helloworld-go.default.example.com helloworld-go helloworld-go.default.example.com
``` ```
@ -140,7 +140,7 @@ assigned an external IP address.
You can also export the host URL as a variable using the following command: You can also export the host URL as a variable using the following command:
```shell ```shell
export HOST_URL=$(kubectl get ksvc helloworld-go --output jsonpath='{.status.domain}') export HOST_URL=$(kubectl get route helloworld-go --output jsonpath='{.status.domain}')
``` ```
If you changed the name from `helloworld-go` to something else when creating If you changed the name from `helloworld-go` to something else when creating