From 378d0a89eb1551484bfe6d2c7f4bb9de40289141 Mon Sep 17 00:00:00 2001
From: Jason Hall <jasonhall@google.com>
Date: Wed, 11 Jul 2018 12:31:26 -0400
Subject: [PATCH] Use revision everywhere instead of branch (#102)

---
 build/builds.md                                       | 6 +++++-
 serving/samples/buildpack-app-dotnet/sample.yaml      | 2 +-
 serving/samples/buildpack-function-nodejs/sample.yaml | 2 +-
 serving/samples/thumbnailer-go/sample.yaml            | 2 +-
 4 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/build/builds.md b/build/builds.md
index 1ba83131f..9d7e23ecd 100644
--- a/build/builds.md
+++ b/build/builds.md
@@ -79,7 +79,7 @@ specifications.  For examples of Builds leveraging templates, see [the build
 template documentation](./build-templates.md).
 
 
-#### With `git` by `branch`
+#### With `git` by branch, tag, commit or ref
 
 ```yaml
 spec:
@@ -92,6 +92,10 @@ spec:
     args: ["cat", "README.md"]
 ```
 
+The `revision` field accepts a branch name, tag name, commit SHA, or any ref.
+See https://git-scm.com/docs/gitrevisions#_specifying_revisions for more
+information.
+
 #### With a `gcs` source
 
 ```yaml
diff --git a/serving/samples/buildpack-app-dotnet/sample.yaml b/serving/samples/buildpack-app-dotnet/sample.yaml
index f38c877d1..3aed1b4ea 100644
--- a/serving/samples/buildpack-app-dotnet/sample.yaml
+++ b/serving/samples/buildpack-app-dotnet/sample.yaml
@@ -18,7 +18,7 @@ spec:
     source:
       git:
         url: https://github.com/cloudfoundry-samples/dotnet-core-hello-world
-        branch: master
+        revision: master
     template:
       name: buildpack
       arguments:
diff --git a/serving/samples/buildpack-function-nodejs/sample.yaml b/serving/samples/buildpack-function-nodejs/sample.yaml
index 2d6d1200f..920887937 100644
--- a/serving/samples/buildpack-function-nodejs/sample.yaml
+++ b/serving/samples/buildpack-function-nodejs/sample.yaml
@@ -18,7 +18,7 @@ spec:
     source:
       git:
         url: https://github.com/projectriff-samples/node-square
-        branch: master
+        revision: master
     template:
       name: buildpack
       arguments:
diff --git a/serving/samples/thumbnailer-go/sample.yaml b/serving/samples/thumbnailer-go/sample.yaml
index 426c6adb0..945456761 100644
--- a/serving/samples/thumbnailer-go/sample.yaml
+++ b/serving/samples/thumbnailer-go/sample.yaml
@@ -32,7 +32,7 @@ spec:
     source:
       git:
         url: https://github.com/mchmarny/rester-tester
-        branch: master
+        revision: master
     template:
       name: kaniko
       arguments: