From 5d419226eaf471353e6bc7f0cfea67e386bc863f Mon Sep 17 00:00:00 2001 From: Adam Ross Date: Mon, 26 Nov 2018 02:57:22 -0700 Subject: [PATCH] serving/samples/helloworld-dart: simplify and standardize Dockerfile (#501) --- serving/samples/helloworld-dart/Dockerfile | 6 ++++++ serving/samples/helloworld-dart/README.md | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/serving/samples/helloworld-dart/Dockerfile b/serving/samples/helloworld-dart/Dockerfile index b9517974e..6066d9c4d 100644 --- a/serving/samples/helloworld-dart/Dockerfile +++ b/serving/samples/helloworld-dart/Dockerfile @@ -1 +1,7 @@ +# Use Google's official Dart image. +# https://hub.docker.com/r/google/dart-runtime/ FROM google/dart-runtime + +# Configure and document the service HTTP port. +ENV PORT 8080 +EXPOSE $PORT diff --git a/serving/samples/helloworld-dart/README.md b/serving/samples/helloworld-dart/README.md index d1067b5ec..c1fcd2724 100644 --- a/serving/samples/helloworld-dart/README.md +++ b/serving/samples/helloworld-dart/README.md @@ -71,7 +71,13 @@ created using the following instructions. dockerizing your applications, for dart apps this can be done as follows: ```Dockerfile + # Use Google's official Dart image. + # https://hub.docker.com/r/google/dart-runtime/ FROM google/dart-runtime + + # Configure and document the service HTTP port. + ENV PORT 8080 + EXPOSE $PORT ``` 5. Create a new file, `service.yaml` and copy the following service definition