From 67cae4aaac6b0fb2b3ecce4384e54c5729a9b5cc Mon Sep 17 00:00:00 2001 From: Jason Hall Date: Fri, 20 Jul 2018 09:33:33 -0700 Subject: [PATCH] Add install instructions from public GitHub repo (#192) * Use public build template URLs * include buildpack samples --- serving/samples/build-private-repo-go/README.md | 2 +- serving/samples/buildpack-app-dotnet/README.md | 4 ++-- serving/samples/buildpack-function-nodejs/README.md | 5 ++++- serving/samples/thumbnailer-go/README.md | 2 +- 4 files changed, 8 insertions(+), 5 deletions(-) diff --git a/serving/samples/build-private-repo-go/README.md b/serving/samples/build-private-repo-go/README.md index 1bd3a0312..4b6014aea 100644 --- a/serving/samples/build-private-repo-go/README.md +++ b/serving/samples/build-private-repo-go/README.md @@ -137,7 +137,7 @@ template](https://github.com/knative/build-templates/blob/master/kaniko/kaniko.y in the [build-templates](https://github.com/knative/build-templates/) repo. ```shell -kubectl apply -f kaniko.yaml +kubectl apply -f https://raw.githubusercontent.com/knative/build-templates/master/kaniko/kaniko.yaml ``` ### Using this in Configuration. diff --git a/serving/samples/buildpack-app-dotnet/README.md b/serving/samples/buildpack-app-dotnet/README.md index 539b72fd6..f165f5cb5 100644 --- a/serving/samples/buildpack-app-dotnet/README.md +++ b/serving/samples/buildpack-app-dotnet/README.md @@ -19,7 +19,7 @@ in the [build-templates](https://github.com/knative/build-templates/) repo. First, install the Buildpack build template from that repo: ```shell -kubectl apply -f buildpack.yaml +kubectl apply -f https://raw.githubusercontent.com/knative/build-templates/master/buildpack/buildpack.yaml ``` Then you can deploy this to Knative Serving from the root directory via: @@ -82,5 +82,5 @@ To clean up the sample service: # Clean up the serving resources kubectl delete -f serving/samples/buildpack-app-dotnet/sample.yaml # Clean up the build template -kubectl delete -f buildpack.yaml +kubectl delete buildtemplate buildpack ``` diff --git a/serving/samples/buildpack-function-nodejs/README.md b/serving/samples/buildpack-function-nodejs/README.md index ee8c1b253..76434d7b6 100644 --- a/serving/samples/buildpack-function-nodejs/README.md +++ b/serving/samples/buildpack-function-nodejs/README.md @@ -19,7 +19,7 @@ in the [build-templates](https://github.com/knative/build-templates/) repo. First, install the Buildpack build template from that repo: ```shell -kubectl apply -f buildpack.yaml +kubectl apply -f https://raw.githubusercontent.com/knative/build-templates/master/buildpack/buildpack.yaml ``` Then you can deploy this to Knative Serving from the root directory via: @@ -79,5 +79,8 @@ $ curl http://${SERVICE_IP}/ -H "Host: $SERVICE_HOST" -H "Content-Type: applicat To clean up the sample service: ```shell +# Clean up the serving resources kubectl delete -f serving/samples/buildpack-function-nodejs/sample.yaml +# Clean up the build template +kubectl delete buildtemplate buildpack ``` diff --git a/serving/samples/thumbnailer-go/README.md b/serving/samples/thumbnailer-go/README.md index 50cd63545..de45379d3 100644 --- a/serving/samples/thumbnailer-go/README.md +++ b/serving/samples/thumbnailer-go/README.md @@ -89,7 +89,7 @@ perl -pi -e "s@DOCKER_REPO_OVERRIDE@$REPO@g" sample.yaml # Install the Kaniko build template used to build this sample (in the # build-templates repo). -kubectl apply -f kaniko.yaml +kubectl apply -f https://raw.githubusercontent.com/knative/build-templates/master/kaniko/kaniko.yaml ``` Now, if you look at the `status` of the revision, you will see that a build is in progress: