Add DomainInternal to status for Route and Service (#1586)

* Add ServiceName to status for resources that create services

For resoruces that own a core Kubernetes Services, the name of the
service should be exposed on the resoruce's status. The Revision
resources already exposes `.status.serviceName`, this PR adds the same
property for the Route and Knative Service resources.

Yes, it's a bit strange to have a Serivce include the Service name in
it's status, ¯\_(ツ)_/¯

Fixes: #1584

* Review feedback

- typos
- added status property to spec.md

* Add conformance tests

* Add DomainInternal to status for Service, Route and Revision

* Drop ServiceName from Service and Route

* Update resource spec

* Remove DomainInternal from Revision

* dead code

* Update conformance test with TODOs
This commit is contained in:
Scott Andrews 2018-07-16 21:14:30 -04:00 committed by Google Prow Robot
parent 32951b755a
commit 7c9b9aca5c
1 changed files with 14 additions and 1 deletions

View File

@ -78,6 +78,10 @@ status:
# along with a cluster-specific prefix (here, mydomain.com).
domain: my-service.default.mydomain.com
# domainInternal: A DNS name for the default (traffic-split) route which can
# be accessed without leaving the cluster environment.
domainInternal: my-service.default.svc.cluster.local
traffic:
# current rollout status list. configurationName references
# are dereferenced to latest revision
@ -286,6 +290,11 @@ status:
# Note that logs may still be access controlled separately from
# access to the API object.
logUrl: "http://logging.infra.mycompany.com/...?filter=revision_uid=a1e34&..."
# serviceName: The name for the core Kubernetes Service that fronts this
# revision. Typically, the name will be the same as the name of the
# revision.
serviceName: myservice-a1e34
```
@ -367,7 +376,11 @@ status:
# domain: The hostname used to access the default (traffic-split)
# route. Typically, this will be composed of the name and namespace
# along with a cluster-specific prefix (here, mydomain.com).
domain: my-service.default.mydomain.com
domain: myservice.default.mydomain.com
# domainInternal: A DNS name for the default (traffic-split) route which can
# be accessed without leaving the cluster environment.
domainInternal: myservice.default.svc.cluster.local
# current rollout status list. configurationName references
# are dereferenced to latest revision