From 8016ad1a4889ecf8108625e5de905309b81964df Mon Sep 17 00:00:00 2001 From: Dan Gerdesmeier Date: Fri, 15 Feb 2019 16:11:44 -0800 Subject: [PATCH] Address comments from #802 (#901) The previous PR has already been merged. This one addresses outstanding comments on pull request #802. --- serving/accessing-metrics.md | 4 ++-- serving/setting-up-custom-ingress-gateway.md | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/serving/accessing-metrics.md b/serving/accessing-metrics.md index 8780b9bcd..5e9c9b25c 100644 --- a/serving/accessing-metrics.md +++ b/serving/accessing-metrics.md @@ -46,8 +46,8 @@ The following dashboards are pre-installed with Knative Serving: ## Prometheus -Grafana provides a richer set of graphing functionality than Prometheus. -However, it can often times be useful to access Prometheus for debugging. +Although Grafana provides a richer set of graphing functionality, Prometheus can +still be useful for debugging. 1. To open Prometheus, enter the following command: ```shell diff --git a/serving/setting-up-custom-ingress-gateway.md b/serving/setting-up-custom-ingress-gateway.md index 0ae7336ec..ab98fd6c4 100644 --- a/serving/setting-up-custom-ingress-gateway.md +++ b/serving/setting-up-custom-ingress-gateway.md @@ -1,8 +1,5 @@ # Setting Up Custom Ingress Gateway -[TODO: Update instructions using -Helm](https://github.com/knative/docs/issues/875) - Knative uses a shared ingress Gateway to serve all incoming traffic within Knative service mesh, which is the `knative-ingress-gateway` Gateway under `knative-serving` namespace. By default, we use Istio gateway service