Update ROLES.md (#153)

Copy edits
This commit is contained in:
Peter Delaney 2018-07-17 18:01:37 -07:00 committed by Google Prow Robot
parent 3ce38ac578
commit 96e24e3585
1 changed files with 11 additions and 9 deletions

View File

@ -14,10 +14,12 @@ grants.
## Role Summary
Here is the set of roles we use within the Knative community, the general
responsibilities expected by individuals in each role, the requirements
necessary to join or stay in a given role, and the concrete manifestation of the
role in terms of permissions and privileges.
The following table lists the roles we use within the Knative community. The
table describes:
* General responsibilities expected by individuals in each role
* Requirements necessary to join or stay in a given role
* How the role manifests in terms of permissions and privileges.
<table>
<thead>
@ -104,8 +106,8 @@ role in terms of permissions and privileges.
## Collaborator
Individuals may be added as an outside collaborator (with READ access) to a repo
in the Knative GitHub organization without becoming a member. This allows them
to be assigned issues and PRs until they become a member, but will not allow
in the Knative GitHub organization without becoming a member. This role allows
them to be assigned issues and PRs until they become a member, but will not allow
tests to be run against their PRs automatically nor allow them to interact with
the PR bot.
@ -175,7 +177,7 @@ in.
Code approvers are able to both review and approve code contributions. While
code review is focused on code quality and correctness, approval is focused on
holistic acceptance of a contribution including: backwards / forwards
holistic acceptance of a contribution including: backward / forward
compatibility, adhering to API and flag conventions, subtle performance and
correctness issues, interactions with other parts of the system, etc. Approver
status is scoped to a part of the codebase.
@ -210,7 +212,7 @@ approver in an OWNERS file:
* Responsible for project quality control via [code reviews](REVIEWING.md)
* Focus on holistic acceptance of contribution such as dependencies with
other features, backwards / forwards compatibility, API and flag
other features, backward / forward compatibility, API and flag
definitions, etc
* Expected to be responsive to review requests as per [community
@ -230,7 +232,7 @@ and approve design decisions for their area of ownership.
Getting to be a lead of an existing working group:
* Recognized as having expertise in the groups subject matter.
* Recognized as having expertise in the groups subject matter
* Approver for some part of the codebase for at least 3 months