From 996a43d37895ad031e0a8bce464e6df7cbb88959 Mon Sep 17 00:00:00 2001 From: Steren Date: Wed, 30 Jan 2019 10:11:21 -0800 Subject: [PATCH] Simplify Node.js package.json (#825) * Simplify Node.js package.json Since this is a Hello World, I do not think we need the `homepage`, `bugs` and `repository` attributes of package.json, but instead I suggest to keep it short in order to show the actual simplicity of the sample * README missed the dependencies --- serving/samples/helloworld-nodejs/README.md | 5 ++++- serving/samples/helloworld-nodejs/package.json | 8 -------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/serving/samples/helloworld-nodejs/README.md b/serving/samples/helloworld-nodejs/README.md index e09426183..5bbd1d6a6 100644 --- a/serving/samples/helloworld-nodejs/README.md +++ b/serving/samples/helloworld-nodejs/README.md @@ -74,7 +74,10 @@ recreate the source files from this folder. "start": "node app.js" }, "author": "", - "license": "Apache-2.0" + "license": "Apache-2.0", + "dependencies": { + "express": "^4.16.4" + } } ``` diff --git a/serving/samples/helloworld-nodejs/package.json b/serving/samples/helloworld-nodejs/package.json index ab372364f..5caedc277 100644 --- a/serving/samples/helloworld-nodejs/package.json +++ b/serving/samples/helloworld-nodejs/package.json @@ -6,16 +6,8 @@ "scripts": { "start": "node app.js" }, - "repository": { - "type": "git", - "url": "git+https://github.com/knative/docs.git" - }, "author": "", "license": "Apache-2.0", - "bugs": { - "url": "https://github.com/knative/serving/issues" - }, - "homepage": "https://github.com/knative/serving#readme", "dependencies": { "express": "^4.16.4" }