knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Do not add visibility label to Route (#2906) 

* Do not add visibility label to Route

Although https://knative.dev/docs/serving/cluster-local-route/
explains to add the visibility label to `Route`, the label on `Route` is
removed because Route takes over Ksvc's label.

Please see:
```
$ kubectl label route hello-example serving.knative.dev/visibility=cluster-local
route.serving.knative.dev/hello-example labeled

$ kubectl get rt --show-labels
NAME            URL                                        READY   REASON   LABELS
hello-example   http://hello-example.default.example.com   True             serving.knative.dev/service=hello-example
```

If users deployed the app by Route + Configuration instead of Ksvc
this makes sense but it is very rare (I think) and we should remove
this instruction.

* Revert "Do not add visibility label to Route"

This reverts commit 8a79c17df4.

* Add explanation when used route without KSvc

* Fix typo
This commit is contained in:
Kenjiro Nakayama 2020-10-15 00:52:31 +09:00 committed by GitHub
parent c80a5cc3e9
commit 9af00c07e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/serving/cluster-local-route.md
View File

@ -38,7 +38,7 @@ To label the KService:
kubectl label kservice ${KSVC_NAME} serving.knative.dev/visibility=cluster-local
```
To label a route:
To label a route when you used Route directly without KService:
```shell
kubectl label route ${ROUTE_NAME} serving.knative.dev/visibility=cluster-local