From 9f04556a89af3726b635043449bc90f6d72f9beb Mon Sep 17 00:00:00 2001 From: Ahmet Alp Balkan Date: Thu, 7 Mar 2019 14:35:41 -0800 Subject: [PATCH] samples/grpc-ping-go: don't provide default (#959) I was trying to connect to my grpc service at a custom domain like `grpc-ping.default.IP.IP.IP.IP.xip.io` while omitting -server_host_override and it resulted in bug https://github.com/knative/serving/issues/3307 which took several days to figure out there was a default value for this flag. Removing the default value as nobody's really owning grpc.knative.dev or setting it as the custom domain in this sample. Signed-off-by: Ahmet Alp Balkan --- serving/samples/grpc-ping-go/client/client.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/serving/samples/grpc-ping-go/client/client.go b/serving/samples/grpc-ping-go/client/client.go index cf160a3a2..07aba9cf6 100644 --- a/serving/samples/grpc-ping-go/client/client.go +++ b/serving/samples/grpc-ping-go/client/client.go @@ -16,14 +16,17 @@ import ( var ( serverAddr = flag.String("server_addr", "127.0.0.1:8080", "The server address in the format of host:port") - serverHostOverride = flag.String("server_host_override", "grpc.knative.dev", "") + serverHostOverride = flag.String("server_host_override", "", "") insecure = flag.Bool("insecure", false, "Set to true to skip SSL validation") ) func main() { flag.Parse() - opts := []grpc.DialOption{grpc.WithAuthority(*serverHostOverride)} + var opts []grpc.DialOption + if *serverHostOverride != "" { + opts = append(opts, grpc.WithAuthority(*serverHostOverride)) + } if *insecure { opts = append(opts, grpc.WithInsecure()) }