knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

update Docker file to respect PORT (#523)

This commit is contained in:
Averi Kitsch 2018-11-27 11:51:23 -08:00 committed by Knative Prow Robot
parent 803a5e5a94
commit c41f9193e8
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
serving/samples/helloworld-java/Dockerfile
View File

@ -23,4 +23,5 @@ ENV PORT 8080
EXPOSE $PORT EXPOSE $PORT
# Run the web service on container startup. # Run the web service on container startup.
CMD [ "java", "-Djava.security.egd=file:/dev/./urandom", "-jar", "/helloworld.jar" ] CMD ["java","-Djava.security.egd=file:/dev/./urandom","-Dserver.port=${PORT}","-jar","/helloworld.jar"]

4
serving/samples/helloworld-java/README.md
View File

@ -71,7 +71,7 @@ recreate the source files from this folder.
1. Run the application locally: 1. Run the application locally:
```shell ```shell
./mvnw package && java -jar target/gs-spring-boot-docker-0.1.0.jar ./mvnw package && java -jar target/helloworld-0.0.1-SNAPSHOT.jar
``` ```
Go to `http://localhost:8080/` to see your `Hello World!` message. Go to `http://localhost:8080/` to see your `Hello World!` message.
@ -108,7 +108,7 @@ recreate the source files from this folder.
EXPOSE $PORT EXPOSE $PORT
# Run the web service on container startup. # Run the web service on container startup.
CMD [ "java", "-Djava.security.egd=file:/dev/./urandom", "-jar", "/helloworld.jar" ] CMD ["java","-Djava.security.egd=file:/dev/./urandom","-Dserver.port=${PORT}","-jar","/helloworld.jar"]
``` ```
1. Create a new file, `service.yaml` and copy the following service definition 1. Create a new file, `service.yaml` and copy the following service definition