knative
/
docs
mirror of https://github.com/knative/docs.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add net-istio webhook to spec.registry.override (#3821) 

* Add net-istio webhook to spec.registry.override

container name `webhook` is duplicated with serving and net-istio. But
the example does not have net-istio's webhook so users hit an issue
like https://github.com/knative/operator/issues/519
https://github.com/knative-sandbox/net-istio/pull/560 when we followed
it.

This patch adds the net-istio webhook to the doc.

* Remove white space

* Update docs/admin/install/operator/configuring-serving-cr.md

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>

* Fix to correct deploy name

Co-authored-by: Ashleigh Brennan <abrennan@redhat.com>
This commit is contained in:
Kenjiro Nakayama 2021-06-23 16:43:44 +09:00 committed by GitHub
parent 40a792a1e1
commit d0fa8bb3e2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/admin/install/operator/configuring-serving-cr.md
View File

@ -178,6 +178,7 @@ For example, to given the following images:
| `webhook` | `docker.io/knative-images-repo4/webhook:v0.13.0` | | `webhook` | `docker.io/knative-images-repo4/webhook:v0.13.0` |
| `autoscaler-hpa` | `docker.io/knative-images-repo5/autoscaler-hpa:v0.13.0` | | `autoscaler-hpa` | `docker.io/knative-images-repo5/autoscaler-hpa:v0.13.0` |
| `networking-istio` | `docker.io/knative-images-repo6/prefix-networking-istio:v0.13.0` | | `networking-istio` | `docker.io/knative-images-repo6/prefix-networking-istio:v0.13.0` |
| `(net-istio) webhook` | `docker.io/knative-images-repo6/networking-istio-webhook:v0.13.0` |
| `queue-proxy` | `docker.io/knative-images-repo7/queue-proxy-suffix:v0.13.0` | | `queue-proxy` | `docker.io/knative-images-repo7/queue-proxy-suffix:v0.13.0` |
The operator CR should be modified to include the full list: The operator CR should be modified to include the full list:
@ -197,9 +198,14 @@ spec:
webhook: docker.io/knative-images-repo4/webhook:v0.13.0 webhook: docker.io/knative-images-repo4/webhook:v0.13.0
autoscaler-hpa: docker.io/knative-images-repo5/autoscaler-hpa:v0.13.0 autoscaler-hpa: docker.io/knative-images-repo5/autoscaler-hpa:v0.13.0
networking-istio: docker.io/knative-images-repo6/prefix-networking-istio:v0.13.0 networking-istio: docker.io/knative-images-repo6/prefix-networking-istio:v0.13.0
istio-webhook/webhook: docker.io/knative-images-repo6/networking-istio-webhook:v0.13.0
queue-proxy: docker.io/knative-images-repo7/queue-proxy-suffix:v0.13.0 queue-proxy: docker.io/knative-images-repo7/queue-proxy-suffix:v0.13.0
``` ```
!!! note
If the container name is not unique across all Deployments, DaemonSets and Jobs,
you can prefix the container name with the parent container name and a slash. For example, `istio-webhook/webhook`.
### Download images with secrets: ### Download images with secrets:
If your image repository requires private secrets for If your image repository requires private secrets for