upgrade to latest dependencies (#3782)

bumping knative.dev/hack e35bcb8...3d4b264:
  > 3d4b264 Cleanup release script more (# 74)
  > daccc2c Allow for ignoring arbitrary files with shellcheck (# 48)

Signed-off-by: Knative Automation <automation@knative.team>

go.mod

@@ -30,7 +30,7 @@ require (
 	gopkg.in/go-playground/webhooks.v3 v3.13.0
 	gopkg.in/yaml.v2 v2.3.0
 	honnef.co/go/tools v0.0.1-2020.1.5 // indirect
-	knative.dev/hack v0.0.0-20210609124042-e35bcb8f21ec
+	knative.dev/hack v0.0.0-20210610231243-3d4b264d9472
 )
 
 replace go.opencensus.io => go.opencensus.io v0.20.2

go.sum

@@ -539,8 +539,8 @@ honnef.co/go/tools v0.0.1-2020.1.3/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9
 honnef.co/go/tools v0.0.1-2020.1.4/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
 honnef.co/go/tools v0.0.1-2020.1.5 h1:nI5egYTGJakVyOryqLs1cQO5dO0ksin5XXs2pspk75k=
 honnef.co/go/tools v0.0.1-2020.1.5/go.mod h1:X/FiERA/W4tHapMX5mGpAtMSVEeEUOyHaw9vFzvIQ3k=
-knative.dev/hack v0.0.0-20210609124042-e35bcb8f21ec h1:6+/kYzOv4SSgzvJer3fZS22pzXQG0haZdue2FsheNrM=
+knative.dev/hack v0.0.0-20210610231243-3d4b264d9472 h1:sPXp3IChxDMPFRyP9LGvb+hoa6xP9NhnLhT16Y6Icx0=
-knative.dev/hack v0.0.0-20210609124042-e35bcb8f21ec/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
+knative.dev/hack v0.0.0-20210610231243-3d4b264d9472/go.mod h1:PHt8x8yX5Z9pPquBEfIj0X66f8iWkWfR0S/sarACJrI=
 rsc.io/binaryregexp v0.2.0/go.mod h1:qTv7/COck+e2FymRvadv62gMdZztPaShugOCi3I+8D8=
 rsc.io/quote/v3 v3.1.0/go.mod h1:yEA65RcK8LyAZtP9Kv3t0HmxON59tX3rD+tICJqUlj0=
 rsc.io/sampler v1.3.0/go.mod h1:T1hPZKmBbMNahiBKFy5HrXp6adAjACjK9JXDnKaTXpA=

vendor/knative.dev/hack/library.sh

@@ -773,9 +773,14 @@ function get_latest_knative_yaml_source() {
 function shellcheck_new_files() {
   declare -a array_of_files
   local failed=0
+
+  if [ -z "$SHELLCHECK_IGNORE_FILES" ]; then
+    SHELLCHECK_IGNORE_FILES="^vendor/"
+  fi
+
   readarray -t array_of_files < <(list_changed_files)
   for filename in "${array_of_files[@]}"; do
-    if echo "${filename}" | grep -q "^vendor/"; then
+    if echo "${filename}" | grep -q "$SHELLCHECK_IGNORE_FILES"; then
       continue
     fi
     if file "${filename}" | grep -q "shell script"; then

vendor/knative.dev/hack/release.sh

@@ -18,6 +18,7 @@
 # See README.md for instructions on how to use it.
 
 source $(dirname "${BASH_SOURCE[0]}")/library.sh
+set -x
 
 # Organization name in GitHub; defaults to Knative.
 readonly ORG_NAME="${ORG_NAME:-knative}"
@@ -114,8 +115,11 @@ function hub_tool() {
 # Parameters: $1..$n - arguments to "git push <repo>".
 function git_push() {
   local repo_url="${REPO_UPSTREAM}"
-  [[ -n "${GITHUB_TOKEN}}" ]] && repo_url="${repo_url/:\/\//:\/\/${GITHUB_TOKEN}@}"
+  local git_args=$@
-  git push "${repo_url}" $@
+  # Subshell (parentheses) used to prevent GITHUB_TOKEN from printing in log
+  (set +x;
+   [[ -n "${GITHUB_TOKEN}}" ]] && repo_url="${repo_url/:\/\//:\/\/${GITHUB_TOKEN}@}";
+   git push "${repo_url}" ${git_args} )
 }
 
 # Return the master version of a release.
@@ -359,9 +363,14 @@ function parse_flags() {
         case ${parameter} in
           --github-token)
             [[ ! -f "$1" ]] && abort "file $1 doesn't exist"
+            local old="$(set +o)"
+            # Prevent GITHUB_TOKEN from printing in log
+            set +x
             # Remove any trailing newline/space from token
+            # ^ (That's not what echo -n does, it just doesn't *add* a newline, but I'm leaving it)
             GITHUB_TOKEN="$(echo -n $(cat "$1"))"
             [[ -n "${GITHUB_TOKEN}" ]] || abort "file $1 is empty"
+            eval "$old" # restore xtrace status
             ;;
           --release-gcr)
             KO_DOCKER_REPO=$1

vendor/modules.txt

@@ -286,7 +286,7 @@ gopkg.in/go-playground/webhooks.v3/github
 gopkg.in/yaml.v2
 # honnef.co/go/tools v0.0.1-2020.1.5
 ## explicit
-# knative.dev/hack v0.0.0-20210609124042-e35bcb8f21ec
+# knative.dev/hack v0.0.0-20210610231243-3d4b264d9472
 ## explicit
 knative.dev/hack
 # go.opencensus.io => go.opencensus.io v0.20.2