Adding an EXIT trap to cleanup the /tmp directories containing
1. cloned knative repos (can be huge, especially going forward)
2. `gen-crd-api-reference-docs` tool's repo + built binary
Fixes#1000.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
The API docs generation script can now be called with non-hardcoded commit/tag
refs.
KNATIVE_SERVING_COMMIT=v0.4.0 \
KNATIVE_BUILD_COMMIT=v0.4.0 \
KNATIVE_EVENTING_COMMIT=v0.2.1 \
KNATIVE_EVENTING_SOURCES_COMMIT=v0.2.1 ./gen-api-reference-docs.sh
This should ease docs releases a tiny bit.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
* Update traffic splitting example to use Release mode
This change updates the traffic splitting example to use release mode
introducing the concepts of the mode in three steps. This change also
simplifies running the commands and removes the need to mutate files on
disk to run through the example.
* Use envsubst instead of perl. Simplify image path
* Use long names for arguments
* Update diff statement
* Add envsubst install instructions
* Update issue templates -- separate feature request from new/changing functionality
- We needed a template specifically for user's feature requests; we only had one for bugs and one for upcoming changes to Knative
* Update docs-feature-request.md
* Clarifying Docs contributing roles
* Clarifying how contributors become members/approvers
* Add docs-reviewers alias
* Add gyliu513 as docs reviewer
* Update DOCS-CONTRIBUTING.md
* Update DOCS-CONTRIBUTING.md
* Apply suggestions from code review
Co-Authored-By: samodell <31352624+samodell@users.noreply.github.com>
* Applying comments from DOCS-CONTRIBUTING.md
The text in DOCS-CONTRIBUTING was pulled from ROLES, so I'm making the same changes here as I did there.
* Update DOCS-CONTRIBUTING.md
* Update DOCS-CONTRIBUTING.md
The instructions use the binary name "outyet" which doesn't reflect the helloworld binary actually used. I believe this is a copy-paste from:
https://blog.golang.org/docker
I was trying to connect to my grpc service at a custom domain like
`grpc-ping.default.IP.IP.IP.IP.xip.io` while omitting -server_host_override
and it resulted in bug https://github.com/knative/serving/issues/3307 which
took several days to figure out there was a default value for this flag.
Removing the default value as nobody's really owning grpc.knative.dev or
setting it as the custom domain in this sample.
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
* Doc changes to githubsource for specifying API URL
This commit introduces extra documentation to support the new
functionality on githubsource where you can optionally specify
the baseURL of the github api server - thus enabling the existing
githubsource to be used against both public github and github
enterprise. See https://github.com/knative/eventing-sources/pull/219
* Relative URL and quotes
* Updated instructions to use latest SDK, cleaned up unnecessary imports and added a verification step
* Further simplified the sample
* Revert "Further simplified the sample"
This reverts commit 647bd917d2.
* Update the example to automate IP extraction and use it as a env var.
* {} the variables for better shell
* kotlin example; numbering, same changes
* add env var for domain
RichieEscarez