Commit Graph

7 Commits

Author SHA1 Message Date
Christie Wilson 07c926d956 Update condition `type` in spec and do not assert against `reason` (#903)
* Some spec docs were using `RolloutComplete` for the condition type,
  however as errors.md documents and as discussed in #351, the type
  should actually be `Ready`
* The conformance tests were asserting against the condition `Reason`
  but as per #351 and errors.md, values in this field are for the
  user to consume and should be transpart to client applications.
* errors.md didn't make the latter as clear as mattmoor@'s comment
  in #351 so I copied some of his comment into the doc

Also reorganized some of errors.md to make it easier to identify,
by field, what requirements are.
2018-05-29 17:40:10 -07:00
jonjohnsonjr 29655efa09 Update spec for AllTrafficAssigned conditions (#840)
Instead of setting the name of a missing Revision to "Not found" in
`status.traffic`, just omit the revision entirely, since the error is already
communicated via the conditions' reasons.

Also s/TrafficDropped/AllTrafficAssigned/ to fix outdated docs.
2018-05-23 22:12:08 -07:00
Brenda Chan f529c4b373 Generates logURL for revision (#831)
* Generates logURL for revision
- Uses 'logging.revision-url-template' in ela config to generate
revision URL for a specific revision.
https://github.com/elafros/elafros/issues/649
2018-05-11 10:09:48 -07:00
jonjohnsonjr afada8dae6 Clarify "happy state" condition types (#869)
It wasn't completely clear that "this" and "object name" refer to the
condition Type.
2018-05-10 11:07:24 -07:00
Evan Anderson 1ec350998b Service docs (#685)
* Initial checkin of Service docs (aka "Steve")

* Partial checkpoint on updating spec

* Add service to images

Adds Service to images

* Update the rest of examples

* Reorder errors to group logically into deployment and routing errors.

Introduce Service error documentation, and structure error blocks to show how Service aggregates errors from Route and Configuration.

* Address small comments from @vaikas-google and @mattmoor. Did not refactor service.pinned behavior.
2018-05-07 10:59:23 -07:00
Evan Anderson 9cf3c0879c Make all Conditions positive terminating conditions (#733)
* Update error documentation to address #351

* Update Condition usage to match spec described in #351

* Change "deploying" state to Ready=Unknown rather than Ready=False. Also re-add the "IsFailed" condition, keying off of non-Ready conditions on the revision.

* Address review comments by @sixolet and @mattmoor

* Updated per @sixolet and @mattmoor discussions.

* Update semantics on Ready, which should catch my true/false screwup on BuildSucceeded=False

* Fix added test that was failing in merge.

* Rerun update-codegen.sh

* Also need to update conformance test
2018-04-27 16:53:20 -07:00
Evan Anderson 4ee69f36ed Commit API spec and design doc (#444)
Initial copy/commit of Elafros API design doc, chunked into sections. Also includes initial definitions of Elafros personas.

Still TODO:
- Appendices A-E, which cover extended use cases.
2018-03-27 15:14:54 -07:00