- Remove line with link about managed instio installation as that just links back to the install guide and doesn't provide any specific guidance.
- Improve readability
- remove duplicate statement in the wrong location
- reword incorrect statements
- reword statements to be consistent across the file
- fix incorrect statement referring to `Sequence` instead of `Trigger`
- replace `event-display` with `sequence-display` to match pod name
Signed-off-by: Sameer Vohra <vsameer@vmware.com>
* Adding configuration description for TLS/SASL for the KafkaChannel
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
* Updating based on feedback
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
* 💄 a little more context and polishing
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
* Fixing typo
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
- set weight to 70 so it shows as the last link in the list. This would
then match the intended order in the README.md file
Signed-off-by: Sameer Vohra <vsameer@vmware.com>
* Update .../sequence-termina/README.md
Relocate statement about Sequences to the correct section. It was hiding in the PingSource section ;p
* Update .../sequence-termina/README.md
Relocate statement about sequence container outputs in the "Inspecting results" section to the correct locations with their corresponding commands.
- Drop namespace reference in k8s Job resource as none of the other resources specify a namespace.
- Add verification for job having run
Signed-off-by: Sameer Vohra <vsameer@vmware.com>
Switch `service` to `resources` when referring to internal Knative Eventing.
Why: Disambiguate `service` to refer to an abstraction which has an http endpoint and primarily referring to a K8s Service or Knative Service.
Here, also calling Knative Eventing resources as `services` creates confusion even if the usage is technically correct.
Remove the relative link that links directly to the section above. It also goes to the generic install instructions rather than Eventing specifically.
Signed-off-by: Sameer Vohra <vohra.sam@gmail.com>
* fix: add a reference to eventing sources page instead of having a list
* docs: improve eventing sources readability
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
* fix: use relative path for reference
* fix: use correct link for knative event sources
Co-authored-by: RichieEscarez <rescarez@google.com>
Co-authored-by: Pierangelo Di Pilato <pierangelodipilato@gmail.com>
Co-authored-by: RichieEscarez <rescarez@google.com>
Update pre-reqs to refer to Knative Serving
Why: Since the install instructions breakdown installing Knative "Serving" and "Eventing" as standalone components, we can be more specific here to clarify what is required for App Deployment
* helloworld shell sample: Switch to use CGI bin for the output
Also, httpd is now started by init for proper SIGTERM handling.
If you run the image itself within Docker, note that SIGINT (CTRL-C) is not captured.
Use `docker --init` for being able to stop the containe with CTRL-C
(This is not relevant when used for Knative)
Thanks to @csantanapr for the idea to switch to CGI.
* chore: Removed dynamic parts from the script
It's back now to a simple echo, so that the CI tests pass that
compare on exactly the output of a request. Also this is probably
easier to understand for a user, too.
Based on review feedback.
* chore: Add missing file
Victor Agababov
knative-automation
Ashleigh Brennan
Sameer Vohra
dependabot[bot]
RichieEscarez
Matthias Wessendorf
Evan Anderson
Ville Aikas
Senthilnathan M
Vincent
Lukas Berk
Ricardo Zanini
SaintMalik
Dan Wilson
Zhuang
zhihuiwu
Alex Yang
Aldo Preciado Cuevas
Sameer Vohra
Matt Moore
zhaojizhuang
Dave Syer
Zhimin Xiang
Roland Huß