* Simplify DNS instructions
- make it clearer that the `data:` snippet is truncated.
- Demonstrate the simple use case of using a single custom domain name for all routes.
- fix typo
* use example.com
* Move to using Istio v1alpha3 API.
* Removing ingressInformer from controllers since we no longer need.
* Update typo and utilization target for HPA.
* Add README.md to explain how we create these types.
* Update per PR feedback
* Update per PR feedback.
* Add back the timeout settings.
The timeout headers were added when we used v1alpha2 in order to allow
more time for 0->1 scaling. I accidentally undo that change when
moving to v1alpha3. This adds it back.
* Run hack/update-codegen.sh.
* Update per PR feedback.
* Update per PR feedback.
* Update per PR feedback.
By default the controller is configured to skip resolving
for the following registries:
- ko.local
- dev.local
This should address issue #1093
Co-authored-by: Sukhil Suresh <ssuresh@pivotal.io>
* Remove lingering use of glog
We can't remove it as a dependency, since we need to set its verbosity
level in test/logging.go still.
We can't remove it from pkg/client/clientset/versioned/clientset.go
because it's generated.
This also leaves some references to glog in docs/telemetry.md, since
it's not clear what we should recommend.
* Remove generating logs section
The docs for setting up minikube were using the namespaces and
resource names from elafros instead of knative. The naming changed
slightly, e.g. a knative controller is now called `controller`
instead of `knative-serving-controller`, so one of the loops had
to be broken into 2 statements.
Added steps about redeploying pods after setting up GCR
secrets b/c there is a chicken and egg problem where the namespaces
must exist before you can setup the secrets, but the secrets must
exist before the images can be pulled.
The PR that enabled `MutatingAdmissionWebhook` by default
(https://github.com/kubernetes/minikube/pull/2547) was merged, but
the latest minikube (0.28.0) still did not enable this option
by default b/c providing any arugments overrides all of the defaults,
so we must still set it explicitly.
Made it clear in the setting up knative serving docs that the cluster
admin binding is required, not just for istio.
Use a `NodePort` instead of a `LoadBalancer`
(see https://github.com/kubernetes/minikube/issues/384) - another
step along the road to #608.
* add instruction to set static IP for Ingresses
* Add link in DEVELOPMENT.md to reference setting-up-ingress-static-ip doc
* fix typos
* fix typos
* Update the doc to use 'kubectl patch' to update istio-ingress service IP
* rephrase the doc a little bit
* fix typos
* fix nits
* wrap each line to 80 characters
* Updates to debugging guide
* Update telemetry.md
Edit for clarity, add screenshots, steps, etc. Still need to upload screenshots and add in links
* Add two screenshots of the Kibana UI
* Add urls to screenshots
* Adding troubleshooting on Istio routing
Needs to be more actionable, but this is a start.
* Wording, grammer, etc.
* Typo fix
* Update telemetry.md
* Update telemetry.md
* Update telemetry.md
* Addressing Ivan's comments
* Remove reference to Pantheon
* Update telemetry.md
Clarify the relationship between Kibana and Elasticsearch
* Fixing whitespace so list renders properly
* Responding to Evan's comments
* More updates from Evan's PR comments
* Created a /docs/images folder for Kibana screenshots, fixed line wrapping.
* Adding docs/images folder.
* Making links to images relative.
* Removed hover text from link.
* Conditions proposal
Replace LatestRevisionReady condition with:
Configuration.Status.Ready
Service.Status.ConfigurationReady
Updated Service Status to include:
Ready
ConfigurationReady
RouteReady
The overall condition of any resource can be checked by looking at its
Ready condition. This simplifies the logic for clients that need to poll
for Readiness.
For Service, the status of its owned resources can be checked by looking
at its ConfigurationReady and RouteReady conditions. This saves clients
from having to perform an extra hop to determine why a Service is not
Ready. The Ready condition of a Service should reflect a union of the
Ready conditions of its owned Configuration and Route.
Also fix typo: s/meassage/message/
* Pluralize conditions
* Add missing condition to errors example
* Move revision condition manipulation into revision_types.go
This is the Revision equivalent of #1113
This contains two other unrelated changes:
1. Condense the object construction in `revision_test.go`
1. Reorder the `helloworld` yaml to create the configuration first.
The reason for the second "unrelated" change is that I was seeing the route controller marking the Route as "AllTrafficAssigned = False" because the configuration wasn't created yet.
* Update the conditions spec to eliminate wording about elision.
Eliding conditions can come later, it's a premature optimization,
and I'm not sure we're handling conditions well enough to do it
reliably yet.
* Fix test breakages due to setCondition becoming private.
* Add unit test coverage of the condition logic.
* Clarify isBuildDone through local variable names.
Failed with group name `cluster`:
```
± |master ✓| → gcloud container cluster get-credentials ssuresh-knative-dev
ERROR: (gcloud.container) Invalid choice: 'cluster'. Did you mean 'clusters'?
Usage: gcloud container [optional flags] <group | command>
group may be builds | clusters | images | node-pools | operations
command may be get-server-config
For detailed information on this command and its flags, run:
gcloud container --help
```
Works with group name `clusters`:
```
± |master ✓| → gcloud container clusters get-credentials ssuresh-knative-dev
Fetching cluster endpoint and auth data.
kubeconfig entry generated for ssuresh-knative-dev.
```
Today the "Ready" condition strictly reflects whether the ingress has become available and not whether the revisions they route two have been programmed into route rules. In #986 Jon is adding AllTrafficAssigned to cover revision readiness, but this doesn't change the fact that the ingress becoming ready will cause the Route to become "Ready", even if traffic is unassigned.
This changes the original sense of "Ready" into "IngressReady", and predicates the new "Ready" on "IngressReady" and "AllTrafficAssigned".
Progress on: https://github.com/knative/serving/issues/1056
Fixes: https://github.com/knative/serving/issues/1074
Ryan Gregg
Bernd Krannich
Jason Hall
Steren
jonjohnsonjr
Nghia Tran
Sukhil Suresh
Tanzeeb Khalili
Mark Fisher
Thomas Risberg
Christie Wilson
jessiezcc
Zhimin Xiang
Sam O'Dell
Mustafa Demirhan
Mark Chmarny
Glyn Normington
Joseph Burnett
Evan Anderson
Matt Moore