Commit Graph

32 Commits

Author SHA1 Message Date
Adam Ross f36f33e317 serving/samples/helloworld-nodejs: specifically require package.json (#956) 2019-03-06 11:28:41 -08:00
Matt Moore 4037374784 Manually run prettier.io (#880)
* Manually run prettier.io

Trying to fix the stuff that hits prettier.io bugs.

* Fix prettier.io issues.
2019-02-07 16:04:41 -08:00
Steren 0d0f53a0ab Node.js sample: Use index.js instead of app.js. (#849)
* Use index.js instead of app.js.

index.js is the more idiomatic for Node.js developers.
Indeed, it is the default value that npm start uses if no start script is provided.

* Update package.json

* Update README.md

* Update package.json
2019-01-31 10:35:37 -08:00
Steren 996a43d378 Simplify Node.js package.json (#825)
* Simplify Node.js package.json 

Since this is a Hello World, I do not think we need the `homepage`, `bugs` and `repository` attributes of package.json, but instead I suggest to keep it short in order to show the actual simplicity of the sample

* README missed the dependencies
2019-01-30 10:11:21 -08:00
Adam Ross 921aa488a9 serving/samples: remove EXPOSE directive from helloworld (#644)
* serving/samples: remove EXPOSE directive from helloworld

* serving/samples: update ENV PORT comment for clarified purpose

* serving/samples: update README for Dockerfile changes
2019-01-24 10:10:34 -08:00
Steren 5b5341f6f5 Use template literals in node sample (#801)
* Use template literals in node sample

* update README
2019-01-23 16:18:34 -08:00
Steren 73e1ce86cd Refactor Node.js sample to use arrow functions (#749) 2019-01-17 15:50:31 -08:00
Steren 530b5ee51d fix Dockerfile comment (#783)
* fix Dockerfile comment

* fix readme
2019-01-17 11:25:31 -08:00
Nghia Tran 01b818c33f Update docs to use correct ingress gateway service. (#700)
* Update docs to use correct ingress gateway service.

* Update wording of knative-ingressgateway deprecation.

* Update wording of knative-ingressgateway deprecation per feeeback.
2019-01-16 08:42:31 -08:00
Steren 5de45fb22d Remove license header for Node.js sample (#745)
This is a 15 line trivial hello world, a 15 line license header adds unnecessary complexity.
Many other samples do not include a license header.
The license is already captured at the root of the repository.
2019-01-10 15:16:29 -08:00
Adam Ross 2a5147bd9b serving/samples: update helloworld-nodejs to nodejs v10 (#651) 2018-12-19 11:39:35 -08:00
mattmoor-sockpuppet c64c63a160 Format markdown (#626)
Produced via: `prettier --write --prose-wrap=always $(find -name '*.md' | grep -v vendor | grep -v .github)`
2018-12-04 14:34:25 -08:00
mattmoor-sockpuppet 41462c69e1 Format markdown (#620)
Produced via: `prettier --write --proseWrap=always $(find -name '*.md' | grep -v vendor)`
2018-12-03 13:54:25 -08:00
Jonas Finnemann Jensen b11a0d4de3 Fix example response (#451)
We specify `TARGET='Node.js Sample v1'` in `service.yaml`, so it would be surprising if this isn't printed in the response.
2018-11-29 13:48:23 -08:00
Averi Kitsch 803a5e5a94 update dockerfile to be consistent (#566) 2018-11-27 11:33:22 -08:00
Adam Ross ab11b92622 serving/samples/helloworld-nodejs: simplify and standardize Dockerfile (#507) 2018-11-19 17:03:19 -08:00
RichieEscarez 74ed0fd04a Use the ksvc shortname for services (#492)
* Replace services.serving.knative.dev with ksvc

* Replace -f with long flag --filename
2018-11-02 15:59:34 -07:00
Jonas Finnemann Jensen bff003dfe0 docker -> Dockerfile for syntax highlighting (#450)
* Fixed `docker` to `Dockerfile` for highlighting in markdown code fence

Instead of doing

        ```docker

We should do:

        ```Dockerfile

to get syntax highlighting on github.
2018-11-02 15:50:35 -07:00
Adam Ross e3516ffaf9 serving/helloworld-nodejs: Respect the PORT env var (#458) 2018-10-24 11:47:31 -07:00
Joseph Burnett d1b78c4832 Make the Clojure greeting unscary. (#465) 2018-10-22 14:10:30 -07:00
Steren 9ea6e2c65d Make samples less scary when no env var is provided (#443)
* Node.js

* Python

* csharp

* go

* other samples

* Fix Node README
2018-10-08 11:19:25 -07:00
Ryan Gregg 08ab237cb3 Revert ksvc changes (#442) 2018-10-05 14:30:24 -07:00
Tyler Auerbeck b2254cbb42 Update docs to use kubectl long flags (#372)
* Update docs to use kubectl long flags

* adding back in the --filename flag (lost when manually merged)

* notice a few missed

* notice a few missed '-f' flags

* change -o to --output
2018-09-12 09:46:03 -07:00
Sam O'Dell 00d6cec8ca services.serving.knative.dev -> ksvc, adding check install guide (#360)
* services.serving.knative.dev -> ksvc, adding check install guide

* Updating image to add outline

* Making Richie's suggested edits
2018-08-31 09:58:12 -07:00
Matt Moore 9b4b73936c Fix all of the `knative/install` links to point to `knative/docs/install`. (#126) 2018-07-13 17:21:35 -07:00
Nghia Tran b97fa65aec Update samples to not use Ingress. (#60)
* Update samples to not use Ingress.

This is follow-up of https://github.com/knative/serving/pull/1228.  We
moved to Istio v1alpha3 / Gateway which requires a different way to
get the external IP address to send traffic to our samples.

* Also update the command to find service domain.
2018-07-02 14:07:17 -07:00
Ryan Gregg c57f006f4c
Rename to example domain (#44) 2018-07-02 10:00:01 -07:00
Ryan Gregg dba77c7ab3 Add information about where docs go (#55)
* Add information about where docs go

* add samples too
2018-07-02 09:58:46 -07:00
Ryan Gregg 723b407c80
Convert hello world samples to using Docker (#42) 2018-06-28 16:03:16 -07:00
Sam O'Dell 32f9363548 Documentation-related updates to Go, Node, and C# samples (#21) 2018-06-26 14:57:53 -07:00
Ryan Gregg 29fdc3ad52 Rename to service.yaml (#12) 2018-06-25 09:29:04 -07:00
Ryan Gregg f288609da7 Hello world samples for Go, Node, and CSharp (#11)
* Add some hierachy

* Clone helloworld samples from serving

* add ignore files

* remove mac hidden files

* Finish readme

* Tweak formatting

* Update instructions

* Updating go

* Update yaml example

* Fix typo in service name.

* Update readme and yaml

* Update app yaml

* Ignore .vscode folder

* Fix missing newline at EOF

* Update sample to read env variable
2018-06-22 14:21:34 -07:00