knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Python S2I On-Cluster build (#2770) 

Signed-off-by: Matej Vašek <mvasek@redhat.com>
This commit is contained in:
Matej Vašek 2025-04-04 07:27:11 +02:00 committed by GitHub
parent c98b9f67c3
commit 3e75e25506
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cmd/func-util/main.go
View File

@ -86,7 +86,7 @@ func scaffold(ctx context.Context) error {
return fmt.Errorf("cannot load func project: %w", err) return fmt.Errorf("cannot load func project: %w", err)
} }
if f.Runtime != "go" { if f.Runtime != "go" && f.Runtime != "python" {
// Scaffolding is for now supported/needed only for Go. // Scaffolding is for now supported/needed only for Go.
return nil return nil
} }
@ -108,7 +108,17 @@ func scaffold(ctx context.Context) error {
return fmt.Errorf("unable to create .s2i bin dir. %w", err) return fmt.Errorf("unable to create .s2i bin dir. %w", err)
} }
if err := os.WriteFile(filepath.Join(f.Root, ".s2i", "bin", "assemble"), []byte(s2i.GoAssembler), 0755); err != nil { var asm string
switch f.Runtime {
case "go":
asm = s2i.GoAssembler
case "python":
asm = s2i.PythonAssembler
default:
panic("unreachable")
}
if err := os.WriteFile(filepath.Join(f.Root, ".s2i", "bin", "assemble"), []byte(asm), 0755); err != nil {
return fmt.Errorf("unable to write go assembler. %w", err) return fmt.Errorf("unable to write go assembler. %w", err)
} }