knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix: do not override uid/git in buildpack builder (#2819) 

* Fix: do not override uid/git in buildpack builder

Zero value implies override (to root presumably),
we must set it to negative value.

Signed-off-by: Matej Vašek <mvasek@redhat.com>

* Fixup tests

Since we do not override uid/gid==0 we need to make mounted data less
readable to all.

Signed-off-by: Matej Vašek <mvasek@redhat.com>

---------

Signed-off-by: Matej Vašek <mvasek@redhat.com>
This commit is contained in:
Matej Vašek 2025-04-30 04:45:05 +02:00 committed by GitHub
parent f6b5e39b7c
commit 41666714f2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/builders/builders_int_test.go
View File

@ -65,7 +65,7 @@ func TestPrivateGitRepository(t *testing.T) {
}
gitCredsDir := t.TempDir()
err := os.WriteFile(filepath.Join(gitCredsDir, "type"), []byte(`git-credentials`), 0600)
err := os.WriteFile(filepath.Join(gitCredsDir, "type"), []byte(`git-credentials`), 0644)
if err != nil {
t.Fatal(err)
}
@ -74,7 +74,7 @@ func TestPrivateGitRepository(t *testing.T) {
username=developer
password=nbusr123
`
err = os.WriteFile(filepath.Join(gitCredsDir, "credentials"), []byte(gitCred), 0600)
err = os.WriteFile(filepath.Join(gitCredsDir, "credentials"), []byte(gitCred), 0644)
if err != nil {
t.Fatal(err)
}

2
pkg/builders/buildpacks/builder.go
View File

@ -153,6 +153,8 @@ func (b *Builder) Build(ctx context.Context, f fn.Function, platforms []fn.Platf
}
// Pack build options
opts := pack.BuildOptions{
GroupID: -1,
UserID: -1,
AppPath: f.Root,
Image: f.Build.Image,
LifecycleImage: DefaultLifecycleImage,