knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

move template struct to templates.go (#1698)

This commit is contained in:
Luke Kingland 2023-04-25 23:00:45 +09:00 committed by GitHub
parent fd3aca35a3
commit 55a6e2846f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
pkg/functions/repository.go
View File

@ -1,7 +1,6 @@
package functions
import (
"context"
"errors"
"fmt"
"net/url"
@ -64,26 +63,6 @@ type Runtime struct {
Templates []Template
}
// Template is a function project template.
// It can be used to instantiate new function project.
type Template interface {
// Name of this template.
Name() string
// Runtime for which this template applies.
Runtime() string
// Repository within which this template is contained. Value is set to the
// currently effective name of the repository, which may vary. It is user-
// defined when the repository is added, and can be set to "default" when
// the client is loaded in single repo mode. I.e. not canonical.
Repository() string
// Fullname is a calculated field of [repo]/[name] used
// to uniquely reference a template which may share a name
// with one in another repository.
Fullname() string
// Write updates fields of function f and writes project files to path pointed by f.Root.
Write(ctx context.Context, f *Function) error
}
// This structure defines defaults for a function when generating project by a template.Write().
// The structure can be read from manifest.yaml which can exist at level of repository, runtime or template.
type funcDefaults struct {

24
pkg/functions/template.go
View File

@ -7,7 +7,27 @@ import (
"knative.dev/func/pkg/filesystem"
)
// template
// Template is a function project template.
// It can be used to instantiate new function project.
type Template interface {
// Name of this template.
Name() string
// Runtime for which this template applies.
Runtime() string
// Repository within which this template is contained. Value is set to the
// currently effective name of the repository, which may vary. It is user-
// defined when the repository is added, and can be set to "default" when
// the client is loaded in single repo mode. I.e. not canonical.
Repository() string
// Fullname is a calculated field of [repo]/[name] used
// to uniquely reference a template which may share a name
// with one in another repository.
Fullname() string
// Write updates fields of function f and writes project files to path pointed by f.Root.
Write(ctx context.Context, f *Function) error
}
// template default implementation
type template struct {
name string
runtime string
@ -32,6 +52,8 @@ func (t template) Fullname() string {
return t.repository + "/" + t.name
}
// Write the template source files
// (all source code except manifest.yaml and scaffolding)
func (t template) Write(ctx context.Context, f *Function) error {
// Apply fields from the template onto the function itself (Denormalize).