From d5624980d5f31f98bc27e803ae94311491d4d078 Mon Sep 17 00:00:00 2001 From: Matej Vasek Date: Fri, 6 Nov 2020 17:19:10 +0100 Subject: [PATCH] fix: `delete` and `deploy sub-commands respects func.yaml conf --- cmd/delete.go | 7 ++++++- cmd/deploy.go | 7 ++++++- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/cmd/delete.go b/cmd/delete.go index 6a2b7d72..8edaee31 100644 --- a/cmd/delete.go +++ b/cmd/delete.go @@ -52,7 +52,12 @@ func runDelete(cmd *cobra.Command, args []string) (err error) { return fmt.Errorf("the given path '%v' does not contain an initialized Function.", config.Path) } - remover, err := knative.NewRemover(config.Namespace) + ns := config.Namespace + if ns == "" { + ns = function.Namespace + } + + remover, err := knative.NewRemover(ns) if err != nil { return } diff --git a/cmd/deploy.go b/cmd/deploy.go index d5ceb280..5ffd5129 100644 --- a/cmd/deploy.go +++ b/cmd/deploy.go @@ -95,7 +95,12 @@ func runDeploy(cmd *cobra.Command, _ []string) (err error) { pusher := docker.NewPusher() pusher.Verbose = config.Verbose - deployer, err := knative.NewDeployer(config.Namespace) + ns := config.Namespace + if ns == "" { + ns = function.Namespace + } + + deployer, err := knative.NewDeployer(ns) if err != nil { return }