knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

test: revert error suppresion (#2363) 

Signed-off-by: Matej Vašek <mvasek@redhat.com>
This commit is contained in:
Matej Vašek 2024-06-14 08:53:24 +02:00 committed by GitHub
parent 6bb9a3eafe
commit f72b666bd6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 3 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
test/e2e/scenario_runtime-cloudevents_test.go
View File

@ -7,7 +7,6 @@ import (
"path/filepath"
"strings"
"testing"
"time"
"gotest.tools/v3/assert"
"knative.dev/func/test/testhttp"
@ -36,15 +35,7 @@ func lifecycleCloudEventsTest(t *testing.T, language string, builder string) {
knFunc.Exec("create", "--language", language, "--template", "cloudevents", funcPath)
knFunc.Exec("deploy", "--registry", common.GetRegistry(), "--builder", builder, "--path", funcPath)
defer func() {
// temporarily ignore deletion error because Node has broken signal handling
// TODO fix this
if builder == "s2i" && (language == "node" || language == "typescript") && time.Now().Before(time.Date(2024, 5, 31, 0, 0, 0, 0, time.UTC)) {
knFunc.ShouldFailOnError = false
}
knFunc.Exec("delete", "--path", funcPath)
}()
defer knFunc.Exec("delete", "--path", funcPath)
_, functionUrl := common.WaitForFunctionReady(t, funcName)

11
test/e2e/scenario_runtime-http_test.go
View File

@ -8,7 +8,6 @@ import (
"path/filepath"
"strings"
"testing"
"time"
"gotest.tools/v3/assert"
"knative.dev/func/test/testhttp"
@ -76,15 +75,7 @@ func lifecycleHttpTest(t *testing.T, language string, builder string) {
knFunc.Exec("create", "--language", language, "--template", "http", funcPath)
knFunc.Exec("deploy", "--registry", common.GetRegistry(), "--builder", builder, "--path", funcPath)
defer func() {
// temporarily ignore deletion error because Node has broken signal handling
// TODO fix this
if builder == "s2i" && (language == "node" || language == "typescript") && time.Now().Before(time.Date(2024, 5, 31, 0, 0, 0, 0, time.UTC)) {
knFunc.ShouldFailOnError = false
}
knFunc.Exec("delete", "--path", funcPath)
}()
defer knFunc.Exec("delete", "--path", funcPath)
_, functionUrl := common.WaitForFunctionReady(t, funcName)

10
test/oncluster/scenario_runtime_test.go
View File

@ -8,7 +8,6 @@ import (
"path/filepath"
"strings"
"testing"
"time"
"k8s.io/apimachinery/pkg/util/rand"
common "knative.dev/func/test/common"
@ -82,14 +81,7 @@ func runtimeImpl(t *testing.T, lang string, builder string) {
"--builder", builder,
"--git-url", remoteRepo.ClusterCloneURL)
defer func() {
// temporarily ignore deletion error because Node has broken signal handling
// TODO fix this
if builder == "s2i" && (lang == "node" || lang == "typescript") && time.Now().Before(time.Date(2024, 5, 31, 0, 0, 0, 0, time.UTC)) {
knFunc.ShouldFailOnError = false
}
knFunc.Exec("delete", "-p", funcPath)
}()
defer knFunc.Exec("delete", "-p", funcPath)
// -- Assertions --
result := knFunc.Exec("invoke", "-p", funcPath)