knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: pass LISTEN_ADDRESS to runner (#2901) 

Signed-off-by: Matej Vašek <mvasek@redhat.com>
This commit is contained in:
Matej Vašek 2025-07-01 03:58:53 +02:00 committed by GitHub
parent 65de4ac2fc
commit f9bf9fe9cc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/functions/runner.go
View File

@ -171,17 +171,12 @@ func runGo(ctx context.Context, job *Job) (err error) {
cmd.Stderr = os.Stderr cmd.Stderr = os.Stderr
// cmd.Cancel = stop // TODO: use when we upgrade to go 1.20 // cmd.Cancel = stop // TODO: use when we upgrade to go 1.20
// TODO: Update the functions go runtime to accept LISTEN_ADDRESS rather
// than just port in able to allow listening on other interfaces
// (keeping the default localhost only)
if job.Host != "127.0.0.1" {
fmt.Fprintf(os.Stderr, "Warning: the Go functions runtime currently only supports localhost '127.0.0.1'. Requested listen interface '%v' will be ignored.", job.Host)
}
// See the 1.19 [release notes](https://tip.golang.org/doc/go1.19) which state: // See the 1.19 [release notes](https://tip.golang.org/doc/go1.19) which state:
// A Cmd with a non-empty Dir field and nil Env now implicitly sets the PWD environment variable for the subprocess to match Dir. // A Cmd with a non-empty Dir field and nil Env now implicitly sets the PWD environment variable for the subprocess to match Dir.
// The new method Cmd.Environ reports the environment that would be used to run the command, including the implicitly set PWD variable. // The new method Cmd.Environ reports the environment that would be used to run the command, including the implicitly set PWD variable.
// cmd.Env = append(cmd.Environ(), "PORT="+job.Port) // requires go 1.19 // cmd.Env = append(cmd.Environ(), "PORT="+job.Port) // requires go 1.19
cmd.Env = append(cmd.Env, "PORT="+job.Port, "PWD="+cmd.Dir) cmd.Env = append(cmd.Env, "LISTEN_ADDRESS="+net.JoinHostPort(job.Host, job.Port), "PWD="+cmd.Dir)
// Running asynchronously allows for the client Run method to return // Running asynchronously allows for the client Run method to return
// metadata about the running function such as its chosen port. // metadata about the running function such as its chosen port.
@ -274,7 +269,7 @@ func runPython(ctx context.Context, job *Job) (err error) {
func waitFor(ctx context.Context, job *Job, timeout time.Duration) error { func waitFor(ctx context.Context, job *Job, timeout time.Duration) error {
var ( var (
uri = fmt.Sprintf("http://%s:%s%s", job.Host, job.Port, readinessEndpoint) uri = fmt.Sprintf("http://%s%s", net.JoinHostPort(job.Host, job.Port), readinessEndpoint)
interval = 500 * time.Millisecond interval = 500 * time.Millisecond
) )