knative
/
func
mirror of https://github.com/knative/func.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix: in cluster dialer security context is non-privileged (#1181) 

* fix: in cluster dialer sec.ctx. is non-privileged

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: drop all capabilities

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: seccomp

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: unset seccomp profile type

the seccomp profile type must be empty for osh 4.10

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fixup: suppress warnings

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
This commit is contained in:
Matej Vasek 2022-09-06 17:37:43 +02:00 committed by GitHub
parent 317553206a
commit fee8dfcb0c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
k8s/dialer.go
View File

@ -23,7 +23,7 @@ import (
) )
const ( const (
socatImage = "quay.io/boson/alpine-socat:1.7.4.3-r" socatImage = "quay.io/boson/alpine-socat:1.7.4.3-r1-non-root"
) )
// NewInClusterDialer creates context dialer that will dial TCP connections via POD running in k8s cluster. // NewInClusterDialer creates context dialer that will dial TCP connections via POD running in k8s cluster.
@ -102,6 +102,7 @@ func (c *contextDialer) startDialerPod(ctx context.Context) (err error) {
if err != nil { if err != nil {
return return
} }
c.restConf.WarningHandler = restclient.NoWarnings{}
err = setConfigDefaults(c.restConf) err = setConfigDefaults(c.restConf)
if err != nil { if err != nil {
@ -129,6 +130,7 @@ func (c *contextDialer) startDialerPod(ctx context.Context) (err error) {
} }
}() }()
runAsNonRoot := true
pod := &coreV1.Pod{ pod := &coreV1.Pod{
ObjectMeta: metaV1.ObjectMeta{ ObjectMeta: metaV1.ObjectMeta{
Name: c.podName, Name: c.podName,
@ -143,6 +145,12 @@ func (c *contextDialer) startDialerPod(ctx context.Context) (err error) {
Stdin: true, Stdin: true,
StdinOnce: true, StdinOnce: true,
Args: []string{"-u", "-", "OPEN:/dev/null,append"}, Args: []string{"-u", "-", "OPEN:/dev/null,append"},
SecurityContext: &coreV1.SecurityContext{
Privileged: new(bool),
AllowPrivilegeEscalation: new(bool),
RunAsNonRoot: &runAsNonRoot,
Capabilities: &coreV1.Capabilities{Drop: []coreV1.Capability{"ALL"}},
},
}, },
}, },
DNSPolicy: coreV1.DNSClusterFirst, DNSPolicy: coreV1.DNSClusterFirst,