Commit Graph

11 Commits

Author SHA1 Message Date
Matej Vasek 966a150c58
fix: podman auto-svc has own control group (#1239)
This keeps the podman process alive while `func` receives
SIGKILL or SIGTERM.
We must keep podman alive for cleanup (e.g. container removal).

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-09-14 07:21:49 +00:00
Matej Vasek 1f5a95a4a7
Improvements for podman on Windows and macOS (#1230)
* fix: pack docker socket mounting with npipe

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* feat: trust ssh connection by podman machine

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* fix: socket mount on macOS with podman machine

The `podman machine start` outputs recipe for DOCKER_HOST setting,
following the recipe it was causing troubles,
since path in host OS and in the podman VM is different.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* chore: use go-winio library for handling npipes

Replacing unmaintained an buggy library.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* test: added test for podman machine auto connect

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-09-12 17:26:46 +00:00
Matej Vasek a6c885ef04
feat: UX improvements for docker/podman usage (#1224)
* Better error message I docker/podman not present.
* Auto detect podman machine's socket on mac/win.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-09-09 13:34:29 +00:00
Matej Vasek 51b99c0e67
fix: premature Close() of docker client (#1066)
* Fix docker client lifecycle

Avoid premature Close() of docker client.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* Guard for usage of docker client after close

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-06-16 17:14:17 +00:00
Matej Vasek 0aa8fe81bd
Better error message for podman auto service (#1030)
* Better error message for podman auto svc

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* change per review request

Co-authored-by: Lance Ball <lball@redhat.com>

Co-authored-by: Lance Ball <lball@redhat.com>
2022-06-09 07:03:38 +00:00
Matej Vasek ccfa02afdf
Use struct embedding instead of generated code (#1016)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2022-05-12 01:39:37 +00:00
Luke Kingland a91bcc5fcf
feat: s2i builder with preliminary node support (#923)
* fix: stuck build ticker

* feat: s2i builder prototype

* default builders

* use s2i fork with updated docker

* in-code builder defaults

* s2i builder verbosity constructor arg

* typed errors

* typed error tests

* remove unneeded env code

* s2i build e2e test

* e2e tests

* update licenses

* cleanup

* codegen debug

* update licenses

* Revert "Update actions (#921)"

This reverts commit 8312b5c560.

* update licenses

* e2e test updates

* use GetDefaultDockerConfig for s2i config

* docker.NewClient docs
2022-04-05 13:08:44 +00:00
Matej Vasek ee96bef9ae
fix: use default socket path for TCP connections (#669)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-11-19 12:16:23 -08:00
Matej Vasek 852626a975
Docker SSH test (#659)
* src: refactor tests

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: add comments

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: fix style

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* test: add test for ssh docker client

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: refactore rename struct

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: more reliable connection disposal

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: avoid unnecessary wrapping

When using dial-stdio the DialContext is not associated
with an SSH connection so wrapper with clean up is not needed.

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: add doc comment

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-11-14 17:18:54 -08:00
Matej Vasek bfdfb760cf
feat: automatically start podman service (#648)
* feat: automatically start podman service

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: refactor rename function

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: add commnets to tests

Signed-off-by: Matej Vasek <mvasek@redhat.com>

* src: refactor rename function

Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-11-11 09:38:38 -08:00
Matej Vasek e1f164d2ca
feat: ssh connection to remote docker daemon (#594)
Signed-off-by: Matej Vasek <mvasek@redhat.com>
2021-11-02 09:39:41 -07:00