mirror of https://github.com/knative/func.git
065006cfb1
* fix: force container=true for pack/s2i builders when not explicitly set - Added logic to automatically set container=true for containerized builders (pack/s2i) when --container flag is not explicitly provided by user - Fixes issue where 'func run --builder=pack' would incorrectly run on host instead of container - Solution checks if builder is pack/s2i and --container flag wasn't changed by user - Resolves #2955 * fix: enforce container mode for pack/s2i builders - Auto-set container=true for pack/s2i when --container not explicitly set - Validate and error on incompatible --builder=pack --container=false combinations - Handle both flags and FUNC_CONTAINER environment variable Fixes #2955 Addresses @gauron99 feedback on explicit container=false validation * added logic to prevent test failure in testfunctionwithoutcontainer and also fixed some formatting issues to prevent test failure * refactored the way of implementation based on the suggestion provided also added the test as requested to do so * fixed the linting errors * fimplemented smart builder/container auto-selection automatically handles pack->container=true and container=false->host builder. also updated the e2e test and added new smartbuilderselection test in run_test.go * fix linting errors |
||
|---|---|---|
| .. | ||
| func | ||
| func-util | ||
| prompt | ||
| templates | ||
| testdata | ||
| build.go | ||
| build_test.go | ||
| client.go | ||
| client_test.go | ||
| completion.go | ||
| completion_util.go | ||
| config.go | ||
| config_envs.go | ||
| config_git.go | ||
| config_git_remove.go | ||
| config_git_set.go | ||
| config_labels.go | ||
| config_labels_test.go | ||
| config_test.go | ||
| config_volumes.go | ||
| create.go | ||
| create_test.go | ||
| delete.go | ||
| delete_test.go | ||
| deploy.go | ||
| deploy_test.go | ||
| describe.go | ||
| describe_test.go | ||
| environment.go | ||
| format.go | ||
| invoke.go | ||
| invoke_test.go | ||
| languages.go | ||
| languages_test.go | ||
| list.go | ||
| list_test.go | ||
| mcp.go | ||
| repository.go | ||
| repository_test.go | ||
| root.go | ||
| root_test.go | ||
| run.go | ||
| run_test.go | ||
| subscribe.go | ||
| subscribe_test.go | ||
| templates.go | ||
| templates_test.go | ||
| tkn_tasks.go | ||
| version.go | ||