knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Log metrics/logging init messages at debug level (#2522)

This commit is contained in:
Antoine Cotten 2022-05-25 17:30:05 +02:00 committed by GitHub
parent 19adf798ef
commit 18f6995887
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
logging/config.go
View File

@ -114,8 +114,8 @@ func newLoggerFromConfig(configJSON, levelOverride string, opts []zap.Option) (*
return nil, zap.AtomicLevel{}, err
}
logger.Info("Successfully created the logger.")
logger.Info("Logging level set to: " + loggingCfg.Level.String())
logger.Debug("Successfully created the logger.")
logger.Debug("Logging level set to: " + loggingCfg.Level.String())
return logger, loggingCfg.Level, nil
}

4
metrics/metrics_worker.go
View File

@ -73,7 +73,7 @@ func (cmd *updateMetricsConfigWithExporter) handleCommand(w *metricsWorker) {
ctx := cmd.ctx
logger := logging.FromContext(ctx)
if isNewExporterRequired(cmd.newConfig) {
logger.Info("Flushing the existing exporter before setting up the new exporter.")
logger.Debug("Flushing the existing exporter before setting up the new exporter.")
flushGivenExporter(curMetricsExporter)
e, f, err := newMetricsExporter(cmd.newConfig, logger)
if err != nil {
@ -88,7 +88,7 @@ func (cmd *updateMetricsConfigWithExporter) handleCommand(w *metricsWorker) {
cmd.done <- err
return
}
logger.Infof("Successfully updated the metrics exporter; old config: %v; new config %v", existingConfig, cmd.newConfig)
logger.Debugf("Successfully updated the metrics exporter; old config: %v; new config %v", existingConfig, cmd.newConfig)
}
setCurMetricsConfigUnlocked(cmd.newConfig)
cmd.done <- nil

2
metrics/prometheus_exporter.go
View File

@ -48,7 +48,7 @@ func newPrometheusExporter(config *metricsConfig, logger *zap.SugaredLogger) (vi
logger.Errorw("Failed to create the Prometheus exporter.", zap.Error(err))
return nil, nil, err
}
logger.Infof("Created Prometheus exporter with config: %v. Start the server for Prometheus exporter.", config)
logger.Debugf("Created Prometheus exporter with config: %v. Start the server for Prometheus exporter.", config)
// Start the server for Prometheus scraping
go func() {
srv := startNewPromSrv(e, config.prometheusHost, config.prometheusPort)