knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the display in the table tests. (#393) 

Currently we're collecting and printing extra objects
as VerbActions, which of course is not what's extra, the extra is the
object wrapped around them. So print that insted.
This commit is contained in:
Victor Agababov 2019-04-19 15:37:27 -07:00 committed by Knative Prow Robot
parent 70ab9cc77d
commit 1b67a06e3a
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
reconciler/testing/table.go
View File

@ -147,7 +147,7 @@ func (r *TableRow) Test(t *testing.T, factory Factory) {
}
if got, want := len(actions.Creates), len(r.WantCreates); got > want {
for _, extra := range actions.Creates[want:] {
t.Errorf("Extra create: %#v", extra)
t.Errorf("Extra create: %#v", extra.GetObject())
}
}
@ -181,7 +181,7 @@ func (r *TableRow) Test(t *testing.T, factory Factory) {
}
if got, want := len(updates), len(r.WantUpdates); got > want {
for _, extra := range updates[want:] {
t.Errorf("Extra update: %#v", extra)
t.Errorf("Extra update: %#v", extra.GetObject())
}
}
@ -225,11 +225,11 @@ func (r *TableRow) Test(t *testing.T, factory Factory) {
}
if len(statusUpdates)+len(updates) != len(actions.Updates) {
var unexpected []clientgotesting.UpdateAction
var unexpected []runtime.Object
for _, update := range actions.Updates {
if update.GetSubresource() != "status" && update.GetSubresource() != "" {
unexpected = append(unexpected, update)
unexpected = append(unexpected, update.GetObject())
}
}
@ -251,7 +251,7 @@ func (r *TableRow) Test(t *testing.T, factory Factory) {
}
if got, want := len(actions.Deletes), len(r.WantDeletes); got > want {
for _, extra := range actions.Deletes[want:] {
t.Errorf("Extra delete: %#v", extra)
t.Errorf("Extra delete: %s/%s", extra.GetNamespace(), extra.GetName())
}
}