Adding common sourceLabels func (#720)

* Adding common sourceLabels func

* fixing feedback from @mattmoor

* fixing typo
This commit is contained in:
Matthias Wessendorf 2019-10-15 18:13:32 +02:00 committed by Knative Prow Robot
parent 9a71140445
commit 2668bdb81a
5 changed files with 93 additions and 0 deletions

View File

@ -62,6 +62,10 @@ aliases:
- steuhs
- yt3liu
source-approvers:
- n3wscott
- vaikas-google
webhook-approvers:
- mattmoor
- grantr

4
source/OWNERS Normal file
View File

@ -0,0 +1,4 @@
# The OWNERS file is used by prow to automatically merge approved PRs.
approvers:
- source-approvers

18
source/doc.go Normal file
View File

@ -0,0 +1,18 @@
/*
Copyright 2019 The Knative Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
// Package source holds utilities for Source developers.
package source

29
source/source_labels.go Normal file
View File

@ -0,0 +1,29 @@
/*
* Copyright 2019 The Knative Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package source
const (
sourceControllerName = "sources.knative.dev/controller"
sourceName = "sources.knative.dev/name"
)
func Labels(name, controllerAgentName string) map[string]string {
return map[string]string{
sourceControllerName: controllerAgentName,
sourceName: name,
}
}

View File

@ -0,0 +1,38 @@
/*
* Copyright 2019 The Knative Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package source
import (
"testing"
"github.com/google/go-cmp/cmp"
)
func TestLabels(t *testing.T) {
sourceLabeles := Labels("foo", "foo-source-controller")
wantTags := map[string]string{
sourceControllerName: "foo-source-controller",
sourceName: "foo",
}
eq := cmp.Equal(sourceLabeles, wantTags)
if !eq {
t.Fatalf("%v is not equal to %v", sourceLabeles, wantTags)
}
}