knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

WaitForServiceEndpoints doesn't take into account not found endpoint (#2576) 

`Endpoints` are created asynchronously so it might not exists as soon
as a sertvice is created.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This commit is contained in:
Pierangelo Di Pilato 2022-08-19 11:00:49 +02:00 committed by GitHub
parent 766f70d9cb
commit 2e08ca63a9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/kube_checks.go
View File

@ -34,6 +34,7 @@ import (
"k8s.io/apimachinery/pkg/util/wait" "k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/kubernetes" "k8s.io/client-go/kubernetes"
k8styped "k8s.io/client-go/kubernetes/typed/core/v1" k8styped "k8s.io/client-go/kubernetes/typed/core/v1"
"knative.dev/pkg/test/logging" "knative.dev/pkg/test/logging"
) )
@ -141,6 +142,9 @@ func WaitForServiceEndpoints(ctx context.Context, client kubernetes.Interface, s
waitErr := wait.PollImmediate(interval, podTimeout, func() (bool, error) { waitErr := wait.PollImmediate(interval, podTimeout, func() (bool, error) {
var err error var err error
endpoints, err = endpointsService.Get(ctx, svcName, metav1.GetOptions{}) endpoints, err = endpointsService.Get(ctx, svcName, metav1.GetOptions{})
if apierrs.IsNotFound(err) {
return false, nil
}
if err != nil { if err != nil {
return false, err return false, err
} }