knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Webhook apicoverage unittest uses Table driven test (#560) 

* Webhook apicoverage unittest uses Table driven test

* feedback updates
This commit is contained in:
chaodaiG 2019-08-07 07:00:56 -07:00 committed by Knative Prow Robot
parent a6e24ef7e5
commit 30a47c2c75
1 changed files with 26 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
test/webhook-apicoverage/resourcetree/updateCoverage_test.go
View File

@ -29,42 +29,33 @@ func TestSimpleStructValue(t *testing.T) {
}
}
func TestPtrValueAllCovered(t *testing.T) {
tree := getTestTree(ptrTypeName, reflect.TypeOf(ptrType{}))
tree.UpdateCoverage(reflect.ValueOf(getPtrTypeValueAllCovered()))
if err := verifyPtrValueAllCovered(tree.Root); err != nil {
t.Fatal(err)
}
}
func TestUpdateCoverage(t *testing.T) {
datas := []struct {
TestName string
name string
typeI interface{}
value interface{}
f func(NodeInterface) error
}{{
"TestPtrValueAllCovered", ptrTypeName, ptrType{}, getPtrTypeValueAllCovered(), verifyPtrValueAllCovered,
}, {
"TestPtrValueSomeCovered", ptrTypeName, ptrType{}, getPtrTypeValueSomeCovered(), verifyPtrValueSomeCovered,
}, {
"TestArrValueAllCovered", arrayTypeName, arrayType{}, getArrValueAllCovered(), verifyArryValueAllCovered,
}, {
"TestArrValueSomeCovered", arrayTypeName, arrayType{}, getArrValueSomeCovered(), verifyArrValueSomeCovered,
}, {
"TestOtherValue", otherTypeName, otherType{}, getOtherTypeValue(), verifyOtherTypeValue,
}}
func TestPtrValueSomeCovered(t *testing.T) {
tree := getTestTree(ptrTypeName, reflect.TypeOf(ptrType{}))
tree.UpdateCoverage(reflect.ValueOf(getPtrTypeValueSomeCovered()))
if err := verifyPtrValueSomeCovered(tree.Root); err != nil {
t.Fatal(err)
}
}
for _, data := range datas {
t.Run(data.TestName, func(t *testing.T) {
tree := getTestTree(data.name, reflect.TypeOf(data.typeI))
tree.UpdateCoverage(reflect.ValueOf(data.value))
if err := data.f(tree.Root); err != nil {
t.Fatal(err)
}
})
func TestArrValueAllCovered(t *testing.T) {
tree := getTestTree(arrayTypeName, reflect.TypeOf(arrayType{}))
tree.UpdateCoverage(reflect.ValueOf(getArrValueAllCovered()))
if err := verifyArryValueAllCovered(tree.Root); err != nil {
t.Fatal(err)
}
}
func TestArrValueSomeCovered(t *testing.T) {
tree := getTestTree(arrayTypeName, reflect.TypeOf(arrayType{}))
tree.UpdateCoverage(reflect.ValueOf(getArrValueSomeCovered()))
if err := verifyArrValueSomeCovered(tree.Root); err != nil {
t.Fatal(err)
}
}
func TestOtherValue(t *testing.T) {
tree := getTestTree(otherTypeName, reflect.TypeOf(otherType{}))
tree.UpdateCoverage(reflect.ValueOf(getOtherTypeValue()))
if err := verifyOtherTypeValue(tree.Root); err != nil {
t.Fatal(err)
}
}