knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix comment to ensure we tell the truth to the world (#1601) 

* Make sure GetCondition actually returns the condition

otherwise we return the temp object that loop variable points at.

* comment

* fix

* meh

* update
This commit is contained in:
Victor Agababov 2020-08-10 15:35:05 -07:00 committed by GitHub
parent 20e1d27cd6
commit 473bba04ee
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apis/duck/v1/status_types.go
View File

@ -74,7 +74,7 @@ func (*Conditions) GetFullType() ducktypes.Populatable {
return &KResource{} return &KResource{}
} }
// GetCondition fetches the condition of the specified type. // GetCondition fetches a copy of the condition of the specified type.
func (s *Status) GetCondition(t apis.ConditionType) *apis.Condition { func (s *Status) GetCondition(t apis.ConditionType) *apis.Condition {
for _, cond := range s.Conditions { for _, cond := range s.Conditions {
if cond.Type == t { if cond.Type == t {