diff --git a/reconciler/testing/generate_name_reactor.go b/reconciler/testing/generate_name_reactor.go index 52ac44951..57ea71d9e 100644 --- a/reconciler/testing/generate_name_reactor.go +++ b/reconciler/testing/generate_name_reactor.go @@ -46,13 +46,11 @@ type GenerateNameReactor struct { // mocking func (r *GenerateNameReactor) Handles(action clientgotesting.Action) bool { create, ok := action.(clientgotesting.CreateAction) - if !ok { return false } objMeta, err := meta.Accessor(create.GetObject()) - if err != nil { return false } diff --git a/reconciler/testing/generate_name_reactor_test.go b/reconciler/testing/generate_name_reactor_test.go index 1fc25e2cc..6a3d3777f 100644 --- a/reconciler/testing/generate_name_reactor_test.go +++ b/reconciler/testing/generate_name_reactor_test.go @@ -71,15 +71,24 @@ func TestGenerateNameReactor(t *testing.T) { lastHandlerInvoked := false fake := &clientgotesting.Fake{} + var mutated *appsv1.Deployment fake.AddReactor("*", "*", func(action clientgotesting.Action) (handled bool, ret runtime.Object, err error) { + create, ok := action.(clientgotesting.CreateAction) + if !ok { + return false, nil, nil + } + deploy, ok := create.GetObject().(*appsv1.Deployment) + if !ok { + return false, nil, nil + } lastHandlerInvoked = true + mutated = deploy return false, nil, nil }) PrependGenerateNameReactor(fake) - mutated := tc.deployment.DeepCopy() - action := clientgotesting.NewCreateAction(deploymentsResource, "namespace", mutated) + action := clientgotesting.NewCreateAction(deploymentsResource, "namespace", tc.deployment) fake.Invokes(action, &appsv1.Deployment{})