knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ListPointer flag should also apply to filtered informers (#2620)

This commit is contained in:
Dave Protasowski 2022-11-01 10:38:05 -04:00 committed by GitHub
parent 2f194914a4
commit 64fc3e502d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
codegen/cmd/injection-gen/generators/filtered_informer.go
View File

@ -41,6 +41,7 @@ type filteredInjectionGenerator struct {
injectionClientSetPackage string
clientSetPackage string
listerPkg string
listerHasPointerElem bool
}
var _ generator.Generator = (*filteredInjectionGenerator)(nil)
@ -92,6 +93,7 @@ func (g *filteredInjectionGenerator) GenerateType(c *generator.Context, t *types
"clientSetInterface": c.Universe.Type(types.Name{Package: g.clientSetPackage, Name: "Interface"}),
"resourceLister": c.Universe.Type(types.Name{Name: g.typeToGenerate.Name.Name + "Lister", Package: g.listerPkg}),
"resourceNamespaceLister": c.Universe.Type(types.Name{Name: g.typeToGenerate.Name.Name + "NamespaceLister", Package: g.listerPkg}),
"listerHasPointerElem": g.listerHasPointerElem,
"groupGoName": namer.IC(g.groupGoName),
"versionGoName": namer.IC(g.groupVersion.Version.String()),
"group": namer.IC(g.groupGoName),
@ -246,7 +248,7 @@ func (w *wrapper) List(selector {{ .labelsSelector|raw }}) (ret []*{{ .type|raw
return nil, err
}
for idx := range lo.Items {
ret = append(ret, &lo.Items[idx])
ret = append(ret, {{if not .listerHasPointerElem}}&{{end}}lo.Items[idx])
}
return ret, nil
}

1
codegen/cmd/injection-gen/generators/packages.go
View File

@ -503,6 +503,7 @@ func versionInformerPackages(basePackage string, groupPkgName string, gv clientg
clientSetPackage: customArgs.VersionedClientSetPackage,
injectionClientSetPackage: filepath.Join(basePackage, "client"),
listerPkg: listerPackagePath,
listerHasPointerElem: customArgs.ListerHasPointerElem,
})
return generators
},