knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove branch examples referencing master. (#1694)

This commit is contained in:
Markus Thömmes 2020-09-09 19:45:50 +02:00 committed by GitHub
parent 34829c0aee
commit 69fcf75ee4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
test/ghutil/fakeghutil/fakeghutil.go
View File

@ -209,7 +209,7 @@ func (fgc *FakeGithubClient) RemoveLabelForIssue(org, repo string, issueNumber i
} }
// ListPullRequests lists pull requests within given repo, filters by head user and branch name if // ListPullRequests lists pull requests within given repo, filters by head user and branch name if
// provided as "user:ref-name", and by base name if provided, i.e. "master" // provided as "user:ref-name", and by base name if provided, i.e. "release-0.19"
func (fgc *FakeGithubClient) ListPullRequests(org, repo, head, base string) ([]*github.PullRequest, error) { func (fgc *FakeGithubClient) ListPullRequests(org, repo, head, base string) ([]*github.PullRequest, error) {
var res []*github.PullRequest var res []*github.PullRequest
PRs, ok := fgc.PullRequests[repo] PRs, ok := fgc.PullRequests[repo]
@ -296,7 +296,7 @@ func (fgc *FakeGithubClient) EditPullRequest(org, repo string, ID int, title, bo
return PR, nil return PR, nil
} }
// CreatePullRequest creates PullRequest, passing head user and branch name "user:ref-name", and base branch name like "master" // CreatePullRequest creates PullRequest, passing head user and branch name "user:ref-name", and base branch name like "release-0.19"
func (fgc *FakeGithubClient) CreatePullRequest(org, repo, head, base, title, body string) (*github.PullRequest, error) { func (fgc *FakeGithubClient) CreatePullRequest(org, repo, head, base, title, body string) (*github.PullRequest, error) {
PRNumber := fgc.getNextNumber() PRNumber := fgc.getNextNumber()
stateStr := string(ghutil.PullRequestOpenState) stateStr := string(ghutil.PullRequestOpenState)

4
test/ghutil/pullrequest.go
View File

@ -37,7 +37,7 @@ const (
type PullRequestState string type PullRequestState string
// ListPullRequests lists pull requests within given repo, filters by head user and branch name if // ListPullRequests lists pull requests within given repo, filters by head user and branch name if
// provided as "user:ref-name", and by base name if provided, i.e. "master" // provided as "user:ref-name", and by base name if provided, i.e. "release-0.19"
func (gc *GithubClient) ListPullRequests(org, repo, head, base string) ([]*github.PullRequest, error) { func (gc *GithubClient) ListPullRequests(org, repo, head, base string) ([]*github.PullRequest, error) {
PRsListOptions := github.PullRequestListOptions{ PRsListOptions := github.PullRequestListOptions{
State: string(PullRequestAllState), State: string(PullRequestAllState),
@ -184,7 +184,7 @@ func (gc *GithubClient) EditPullRequest(org, repo string, ID int, title, body st
return res, err return res, err
} }
// CreatePullRequest creates PullRequest, passing head user and branch name "user:ref-name", and base branch name like "master" // CreatePullRequest creates PullRequest, passing head user and branch name "user:ref-name", and base branch name like "release-0.19"
func (gc *GithubClient) CreatePullRequest(org, repo, head, base, title, body string) (*github.PullRequest, error) { func (gc *GithubClient) CreatePullRequest(org, repo, head, base, title, body string) (*github.PullRequest, error) {
b := true b := true
PR := &github.NewPullRequest{ PR := &github.NewPullRequest{