knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

bump the minimum version to 1.15.1 (#1070) 

* bump the minimum version to 1.15.1

Kubernetes 1.15.0 has a bug in openapi and conversion webhook does not
allow to deploy any Knative resources by kubectl.
To avoid hit the issue, this patch bumps the minimum version to
1.15.1.

Please refer to https://github.com/knative/serving/issues/6787 for
more detail.

* Fix unit test
This commit is contained in:
Kenjiro Nakayama 2020-02-11 08:16:07 +07:00 committed by GitHub
parent b5cc404c03
commit 6a46689984
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
version/version.go
View File

@ -30,7 +30,7 @@ const (
// the Kubernetes minimum version required by Knative.
KubernetesMinVersionKey = "KUBERNETES_MIN_VERSION"
defaultMinimumVersion = "v1.15.0"
defaultMinimumVersion = "v1.15.1"
)
func getMinimumVersion() string {

6
version/version_test.go
View File

@ -41,16 +41,16 @@ func TestVersionCheck(t *testing.T) {
wantError bool
}{{
name: "greater version (patch)",
actualVersion: &testVersioner{version: "v1.15.1"},
actualVersion: &testVersioner{version: "v1.15.2"},
}, {
name: "greater version (minor)",
actualVersion: &testVersioner{version: "v1.16.0"},
}, {
name: "same version",
actualVersion: &testVersioner{version: "v1.15.0"},
actualVersion: &testVersioner{version: "v1.15.1"},
}, {
name: "same version with build",
actualVersion: &testVersioner{version: "v1.15.0+k3s.1"},
actualVersion: &testVersioner{version: "v1.15.1+k3s.1"},
}, {
name: "smaller version",
actualVersion: &testVersioner{version: "v1.14.3"},