found a defaulting bug in the converter for empty addressables. (#1062)

apis/duck/v1alpha1/addressable_types.go

@@ -82,7 +82,7 @@ func (*Addressable) GetFullType() duck.Populatable {
 
 // ConvertUp implements apis.Convertible
 func (a *Addressable) ConvertUp(ctx context.Context, to apis.Convertible) error {
-	url := a.GetURL()
+	url := a.URL
 	switch sink := to.(type) {
 	case *v1.Addressable:
 		sink.URL = url.DeepCopy()

apis/duck/v1alpha1/addressable_types_test.go

@@ -128,6 +128,12 @@ func TestConversion(t *testing.T) {
 		conv:        &Addressable{},
 		wantErrUp:   true,
 		wantErrDown: true,
+	}, {
+		name:        "v1alpha1 - empty",
+		addr:        &Addressable{},
+		conv:        &Addressable{},
+		wantErrUp:   true,
+		wantErrDown: true,
 	}}
 
 	for _, test := range tests {

apis/duck/v1beta1/addressable_types_test.go

@@ -44,6 +44,12 @@ func TestConversion(t *testing.T) {
 		conv:        &v1.Addressable{},
 		wantErrUp:   false,
 		wantErrDown: false,
+	}, {
+		name:        "v1 - empty",
+		addr:        &Addressable{},
+		conv:        &v1.Addressable{},
+		wantErrUp:   false,
+		wantErrDown: false,
 	}, {
 		name: "v1beta1",
 		addr: &Addressable{
@@ -55,6 +61,12 @@ func TestConversion(t *testing.T) {
 		conv:        &Addressable{},
 		wantErrUp:   true,
 		wantErrDown: true,
+	}, {
+		name:        "v1beta1 - empty",
+		addr:        &Addressable{},
+		conv:        &Addressable{},
+		wantErrUp:   true,
+		wantErrDown: true,
 	}}
 
 	for _, test := range tests {