Run codegen (#2221)

This commit is contained in:
Matt Moore 2021-08-20 16:55:05 -07:00 committed by GitHub
parent 52d2a0db1e
commit 9b9bc2a226
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 3 deletions

View File

@ -77,9 +77,13 @@ type ReadOnlyInterface interface {
// controller finalizing v1beta1.Deployment if they want to process tombstoned resources
// even when they are not the leader. Due to the nature of how finalizers are handled
// there are no guarantees that this will be called.
//
// Deprecated: Use reconciler.OnDeletionInterface instead.
type ReadOnlyFinalizer interface {
// ObserveFinalizeKind implements custom logic to observe the final state of v1beta1.Deployment.
// This method should not write to the API.
//
// Deprecated: Use reconciler.ObserveDeletion instead.
ObserveFinalizeKind(ctx context.Context, o *v1beta1.Deployment) reconciler.Event
}
@ -132,7 +136,6 @@ func NewReconciler(ctx context.Context, logger *zap.SugaredLogger, client kubern
if _, ok := r.(reconciler.LeaderAware); ok {
logger.Fatalf("%T implements the incorrect LeaderAware interface. Promote() should not take an argument as genreconciler handles the enqueuing automatically.", r)
}
// TODO: Consider validating when folks implement ReadOnlyFinalizer, but not Finalizer.
rec := &reconcilerImpl{
LeaderAwareFuncs: reconciler.LeaderAwareFuncs{

View File

@ -77,9 +77,13 @@ type ReadOnlyInterface interface {
// controller finalizing v1beta2.Deployment if they want to process tombstoned resources
// even when they are not the leader. Due to the nature of how finalizers are handled
// there are no guarantees that this will be called.
//
// Deprecated: Use reconciler.OnDeletionInterface instead.
type ReadOnlyFinalizer interface {
// ObserveFinalizeKind implements custom logic to observe the final state of v1beta2.Deployment.
// This method should not write to the API.
//
// Deprecated: Use reconciler.ObserveDeletion instead.
ObserveFinalizeKind(ctx context.Context, o *v1beta2.Deployment) reconciler.Event
}
@ -132,7 +136,6 @@ func NewReconciler(ctx context.Context, logger *zap.SugaredLogger, client kubern
if _, ok := r.(reconciler.LeaderAware); ok {
logger.Fatalf("%T implements the incorrect LeaderAware interface. Promote() should not take an argument as genreconciler handles the enqueuing automatically.", r)
}
// TODO: Consider validating when folks implement ReadOnlyFinalizer, but not Finalizer.
rec := &reconcilerImpl{
LeaderAwareFuncs: reconciler.LeaderAwareFuncs{

View File

@ -77,9 +77,13 @@ type ReadOnlyInterface interface {
// controller finalizing v1beta1.Deployment if they want to process tombstoned resources
// even when they are not the leader. Due to the nature of how finalizers are handled
// there are no guarantees that this will be called.
//
// Deprecated: Use reconciler.OnDeletionInterface instead.
type ReadOnlyFinalizer interface {
// ObserveFinalizeKind implements custom logic to observe the final state of v1beta1.Deployment.
// This method should not write to the API.
//
// Deprecated: Use reconciler.ObserveDeletion instead.
ObserveFinalizeKind(ctx context.Context, o *v1beta1.Deployment) reconciler.Event
}
@ -132,7 +136,6 @@ func NewReconciler(ctx context.Context, logger *zap.SugaredLogger, client kubern
if _, ok := r.(reconciler.LeaderAware); ok {
logger.Fatalf("%T implements the incorrect LeaderAware interface. Promote() should not take an argument as genreconciler handles the enqueuing automatically.", r)
}
// TODO: Consider validating when folks implement ReadOnlyFinalizer, but not Finalizer.
rec := &reconcilerImpl{
LeaderAwareFuncs: reconciler.LeaderAwareFuncs{