knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make controller tests reentrant (#1671) 

The stats tests were completely wonky checking some random things
and despite attempt to make them reentrant they weren't so.

So fix that \o/!
             |
             /
This commit is contained in:
Victor Agababov 2020-08-31 14:06:15 -07:00 committed by GitHub
parent 0cec568ad1
commit 9c75061487
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
controller/stats_reporter_test.go
View File

@ -17,6 +17,7 @@ limitations under the License.
package controller
import (
"math"
"strings"
"testing"
"time"
@ -74,18 +75,25 @@ func TestReportReconcile(t *testing.T) {
if d, err := view.RetrieveData("reconcile_count"); err == nil && len(d) == 1 {
initialReconcileCount = d[0].Data.(*view.CountData).Value
}
initialReconcileLatency := float64(0)
initialMin, initialMax := math.SmallestNonzeroFloat64, math.SmallestNonzeroFloat64
initialDistributionCount := int64(0)
if d, err := view.RetrieveData("reconcile_latency"); err == nil && len(d) == 1 {
initialReconcileLatency = d[0].Data.(*view.DistributionData).Sum()
dd := d[0].Data.(*view.DistributionData)
initialMin, initialMax = dd.Min, dd.Max
initialDistributionCount = dd.Count
}
expectSuccess(t, func() error { return r.ReportReconcile(10*time.Millisecond, "true") })
metricstest.CheckCountData(t, "reconcile_count", wantTags, initialReconcileCount+1)
metricstest.CheckDistributionData(t, "reconcile_latency", wantTags, 1, initialReconcileLatency+10, initialReconcileLatency+10)
slow, fast := initialMax+5, initialMin-5
expectSuccess(t, func() error { return r.ReportReconcile(15*time.Millisecond, "true") })
expectSuccess(t, func() error { return r.ReportReconcile(time.Duration(fast)*time.Millisecond, "true") })
metricstest.CheckCountData(t, "reconcile_count", wantTags, initialReconcileCount+1)
metricstest.CheckDistributionData(t, "reconcile_latency", wantTags, initialDistributionCount+1,
fast, initialMax)
expectSuccess(t, func() error { return r.ReportReconcile(time.Duration(slow)*time.Millisecond, "true") })
metricstest.CheckCountData(t, "reconcile_count", wantTags, initialReconcileCount+2)
metricstest.CheckDistributionData(t, "reconcile_latency", wantTags, 2, initialReconcileLatency+10, initialReconcileLatency+15)
metricstest.CheckDistributionData(t, "reconcile_latency", wantTags, initialDistributionCount+2,
fast, slow)
}
func expectSuccess(t *testing.T, f func() error) {