Fixes #2308 TestSpoofingClient_WaitForEndpointState flake (#2387)

test/spoof/spoof_test.go

@@ -24,6 +24,7 @@ import (
 	"fmt"
 	"net/http"
 	"net/url"
+	"time"
 
 	"testing"
 
@@ -111,7 +112,7 @@ func TestSpoofingClient_CheckEndpointState(t *testing.T) {
 				Client:          &http.Client{Transport: tt.transport},
 				Logf:            t.Logf,
 				RequestInterval: 1,
-				RequestTimeout:  1,
+				RequestTimeout:  time.Second,
 			}
 			url := &url.URL{
 				Host:   "fake.knative.net",
@@ -155,10 +156,15 @@ func TestSpoofingClient_WaitForEndpointState(t *testing.T) {
 	}, {
 		name:      "Non matching response triggers more requests",
 		transport: &fakeTransport{response: successResponse},
-		inState: func(resp *Response) (done bool, err error) {
+		inState: func() ResponseChecker {
-			return false, nil
+			var calls atomic.Int32
-		},
+			return func(resp *Response) (done bool, err error) {
-		wantErr:   true,
+				val := calls.Inc()
+				// Stop the looping on the third invocation
+				return val == 3, nil
+			}
+		}(),
+		wantErr:   false,
 		wantCalls: 3,
 	}, {
 		name:      "Retriable error is retried",
@@ -183,7 +189,7 @@ func TestSpoofingClient_WaitForEndpointState(t *testing.T) {
 				Client:          &http.Client{Transport: tt.transport},
 				Logf:            t.Logf,
 				RequestInterval: 1,
-				RequestTimeout:  1,
+				RequestTimeout:  time.Second,
 			}
 			url := &url.URL{
 				Host:   "fake.knative.net",