knative
/
pkg
mirror of https://github.com/knative/pkg.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

make the rt error message clearer (#1492)

This commit is contained in:
Ville Aikas 2020-07-14 16:31:32 -07:00 committed by GitHub
parent 858f1a7b0d
commit cb1281d05c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apis/duck/v1/source_types.go
View File

@ -67,7 +67,7 @@ type CloudEventOverrides struct {
// SourceStatus shows how we expect folks to embed Addressable in
// their Status field.
type SourceStatus struct {
// inherits duck/v1beta1 Status, which currently provides:
// inherits Status, which currently provides:
// * ObservedGeneration - the 'Generation' of the Service that was last
// processed by the controller.
// * Conditions - the latest available observations of a resource's current

4
apis/testing/roundtrip/roundtrip.go
View File

@ -169,7 +169,7 @@ func roundTripViaHub(t *testing.T, gvk schema.GroupVersionKind, scheme, hubs *ru
obj = obj.DeepCopyObject().(convertibleObject)
if !apiequality.Semantic.DeepEqual(original, obj) {
t.Errorf("DeepCopy altered the object, diff: %v", diff(original, obj))
t.Errorf("DeepCopy modified the original object (DeepCopy should not have side-effects), diff: %v", diff(original, obj))
return
}
@ -178,7 +178,7 @@ func roundTripViaHub(t *testing.T, gvk schema.GroupVersionKind, scheme, hubs *ru
}
if !apiequality.Semantic.DeepEqual(original, obj) {
t.Errorf("Conversion to hub (%s) alterted the object, diff: %v", hubGVK, diff(original, obj))
t.Errorf("Conversion to hub (%s) modified the original object (ConvertFrom should not have side-effects), diff: %v", hubGVK, diff(original, obj))
return
}